-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also include stream information in CLI project creation #34034
Conversation
This has been done a long while ago for standard apps but I missed to update the CLI somehow.
🙈 The PR is closed and the preview is expired. |
@MichalMaler pinging you as I'm not sure if the downstream doc overrides |
Hello. I think downstream not override anything ATM. We have this attribute specified in our I will ask @inoxx03 for confirmation. I guess he will have more info about this too :) |
@gsmet I've run a search of our docs set and can confirm that a the moment we do not override the Form what i know, we'll need to override the platform From a long term perspective, I wouldn't exclude the possibility that we might want to override it at some point, in which case we can do 2 things downstream:
Either way I don't think that this change is going to break our docs. @MichalMaler please feel free to follow-up if you know that this change carries a risk of breaking anything downstream, although I don't think it does at the moment. Why exactly was the attribute name change necessary? |
Thanks, I will merge it then. |
just a quick comment - the whole intent on how we made quarkus have notion of platforms and streams is to avoid having to document different behaviors. it should be sufficient to just enable the product registry first and it should use the recommended defaults from that registry. |
so if some productized docs had to make changes like this we would be making differences that shouldn't be necessary. |
This has been done a long while ago for standard apps but I missed to update the CLI somehow.