Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute: add SectionResolutionContext.evaluate() #34017

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Qute: add SectionResolutionContext.evaluate() #34017

merged 1 commit into from
Jun 14, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 13, 2023 •
edited
Loading

@quarkus-bot quarkus-bot bot added the area/qute The template engine label Jun 13, 2023
@mkouba mkouba requested review from gastaldi and FroMage June 13, 2023 14:10
@mkouba mkouba added this to the 3.2 - main milestone Jun 13, 2023
FroMage
FroMage approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, but you should add it to https://quarkus.io/guides/qute-reference#engine-customization which is how I got into this mess :)

@mkouba
Copy link
Contributor Author

mkouba commented Jun 13, 2023

This is great, but you should add it to https://quarkus.io/guides/qute-reference#engine-customization which is how I got into this mess :)

Good point, I'll update the docs as well...

@mkouba mkouba force-pushed the qute-section-helper-utils branch from 4a768af to 2894c98 Compare June 13, 2023 15:14
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 13, 2023
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 14, 2023

Failing Jobs - Building 2894c98

Status Name Step Failures Logs Raw logs
✖ Gradle Tests - JDK 11 Build Failures Logs Raw logs
✔️ Gradle Tests - JDK 11 Windows

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.QuarkusDevDependencyDevModeTest.main line 14 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@mkouba
Copy link
Contributor Author

mkouba commented Jun 14, 2023

@gsmet FYI the io.quarkus.gradle.devmode.QuarkusDevDependencyDevModeTest seems to be flaky.

@mkouba mkouba merged commit 8ba915d into quarkusio:main Jun 14, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 14, 2023
@github-actions
Copy link

🙈 The PR is closed and the preview is expired.

FroMage
FroMage reviewed Jun 15, 2023
View reviewed changes
docs/src/main/asciidoc/qute-reference.adoc

@Override
public CustomSectionHelper initialize(SectionInitContext context) {
if (context.getParameter("foo") == null) {
throw new IllegalStateException("Foo param not found"); <3>
}
return new CustomSectionHelper();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constructor is missing its parameter :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! No problem, I will fix it in a follow-up PR...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not so great, sorry to have taken so long to review :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroMage FroMage FroMage approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/documentation area/qute The template engine triage/flaky-test
Projects
None yet
Milestone
3.2.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@mkouba @gastaldi @FroMage