Container JIB: Update base ubi openjdk to tag version to 1.16 #34009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable. @cescoffier WDYT? |
cescoffier
approved these changes
Jun 13, 2023
gsmet
requested changes
Jun 13, 2023
There was a problem hiding this comment.
Thanks for that but could we do it globally?
See https://github.com/quarkusio/quarkus/pull/32753/files for the full set of changes needed.
quarkus-bot
bot
added
area/devtools
This comment has been minimized.
This comment has been minimized.
|
@gsmet I changed all occurences. Hope I found everything. Maybe somekind of bot should automaticlly look for this in the future??? |
|
IDeally yes, but we need to be careful and conservative. I'm only updating on CVE. |
gsmet
added
the
triage/waiting-for-ci
gsmet
force-pushed
the
jib-ubi-version-update
branch
from
3a34930 to
cfbf91f
Compare
|
I squashed the commits and force pushed. |
This comment has been minimized.
This comment has been minimized.
|
These CI-erros don't look releated or am I overlooking something |
geoand
force-pushed
the
jib-ubi-version-update
branch
from
5a7d48d to
46fea1e
Compare
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.