Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate fullStacktraces #33987

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Jun 12, 2023

GraalVM 23.1+ will have this option deprecated doing nothing. Deprecate it in Quarkus as well.

See for example this CI run:
https://github.com/graalvm/mandrel/actions/runs/5227497104/jobs/9439379340#step:12:140

Fixes: Karm/mandrel-integration-tests#167

GraalVM 23.1+ will have this option deprecated doing nothing. Deprecate
it in Quarkus as well.
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 12, 2023

Failing Jobs - Building d4bcd81

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
JVM Tests - JDK 19 Build Failures Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/amazon-lambda/deployment 
! Skipped: extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment integration-tests/amazon-lambda and 6 more

📦 extensions/amazon-lambda/deployment

io.quarkus.amazon.lambda.deployment.testing.LambdaDevServicesContinuousTestingTestCase.testLambda line 48 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

⚙️ JVM Tests - JDK 19 #

- Failing: extensions/amazon-lambda/deployment 
! Skipped: extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment integration-tests/amazon-lambda and 6 more

📦 extensions/amazon-lambda/deployment

io.quarkus.amazon.lambda.deployment.testing.LambdaDevServicesContinuousTestingTestCase.testLambda line 48 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

@jerboaa
Copy link
Contributor Author

jerboaa commented Jun 13, 2023

CI failures seem unrelated.

@geoand geoand requested a review from zakkak June 13, 2023 09:41
@jerboaa
Copy link
Contributor Author

jerboaa commented Jun 14, 2023

@geoand FWIW, @zakkak is away for while. If somebody else could have a look too, it would be good. @galderz or @Karm perhaps?

@galderz
Copy link
Member

galderz commented Jun 15, 2023

Looks good, thanks @jerboaa

@geoand geoand merged commit 4df65fc into quarkusio:main Jun 15, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone Jun 15, 2023
*/
@WithDefault("true")
@Deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we are still on 23.0, shouldn't we delay the deprecation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think this is still fine. Users need a way to become aware. Deprecating it now is the right call, imo. On the next release using it would do nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimesSmokeTest.quarkusFullMicroProfile failing due to deprecated StackTrace option
4 participants