-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate fullStacktraces #33987
Deprecate fullStacktraces #33987
Conversation
GraalVM 23.1+ will have this option deprecated doing nothing. Deprecate it in Quarkus as well.
Failing Jobs - Building d4bcd81
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 Windows #- Failing: extensions/amazon-lambda/deployment
! Skipped: extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment integration-tests/amazon-lambda and 6 more 📦 extensions/amazon-lambda/deployment✖
⚙️ JVM Tests - JDK 19 #- Failing: extensions/amazon-lambda/deployment
! Skipped: extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment integration-tests/amazon-lambda and 6 more 📦 extensions/amazon-lambda/deployment✖
|
CI failures seem unrelated. |
Looks good, thanks @jerboaa |
*/ | ||
@WithDefault("true") | ||
@Deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we are still on 23.0, shouldn't we delay the deprecation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think this is still fine. Users need a way to become aware. Deprecating it now is the right call, imo. On the next release using it would do nothing.
GraalVM 23.1+ will have this option deprecated doing nothing. Deprecate it in Quarkus as well.
See for example this CI run:
https://github.com/graalvm/mandrel/actions/runs/5227497104/jobs/9439379340#step:12:140
Fixes: Karm/mandrel-integration-tests#167