Fix property "http-action-port-name" is ignored by Kubernetes #33979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When binding a new port: ``` quarkus.kubernetes.ports.custom.container-port=8888 ``` The new port name is `custom` which port `8888`. Then, if we configure any probe to use the port name `custom`: ``` quarkus.kubernetes.readiness-probe.http-action-port-name=custom ``` The generated probe wrongly kept using the port name `http`.
Sgitario
force-pushed
the
fix_ApplyHttpGetActionPortDecorator
branch
from
9387120 to
d80e9c4
Compare
Failing Jobs - Building d80e9c4
Failures⚙️ JVM Tests - JDK 17 Windows #- Failing: integration-tests/kubernetes/quarkus-standard-way
📦 integration-tests/kubernetes/quarkus-standard-way✖ |
|
I didn't backport this one to 3.1 as it doesn't apply cleanly. I suspect we would need to backport other PRs to get this one in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When binding a new port:
The new port name is
customwhich port8888.Then, if we configure any probe to use the port name
custom:The generated probe wrongly kept using the port name
http.Furthermore, we fix the support of the apply port decorators to use the correct config references.