Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Linux line endings for mvnw #33947

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Force Linux line endings for mvnw #33947

merged 1 commit into from
Jun 13, 2023

Conversation

albers
Copy link
Contributor

@albers albers commented Jun 9, 2023

Without this fix, executing mvnw on Windows in a Cygwin environment fails:

$ ./mvnw validate
./mvnw: line 20: $'\r': command not found
./mvnw: line 35: $'\r': command not found
./mvnw: line 56: syntax error near unexpected token `$'in\r''
'/mvnw: line 56: `case "$(uname)" in

Execution is successful if .mvnw has Linux line endings.

Cygwin on Windows refuses to execute files with CRLF line endings.
@quarkus-bot quarkus-bot bot added the env/windows Impacts Windows machines label Jun 9, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 12, 2023

Failing Jobs - Building 00a8c88

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 19
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
Native Tests - HTTP Build ⚠️ Check → Logs Raw logs

@gsmet gsmet merged commit 266a6c7 into quarkusio:main Jun 13, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone Jun 13, 2023
@albers albers deleted the mvnw-cygwin branch June 13, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env/windows Impacts Windows machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants