Add optional native flag to build PIE binaries #33931

galderz · 2023-06-09T09:44:18Z

Closes #33524. Adds quarkus.native.pie configuration option. Usage and verification:

$ mvn package -Dquarkus.native.pie=true -Dnative
...
file getting-started/target/getting-started-1.0.0-SNAPSHOT-runner
getting-started/target/getting-started-1.0.0-SNAPSHOT-runner: ELF 64-bit LSB pie executable, ...

Compared with:

$ mvn package -Dnative
file getting-started/target/getting-started-1.0.0-SNAPSHOT-runner
getting-started/target/getting-started-1.0.0-SNAPSHOT-runner: ELF 64-bit LSB executable, ...

Commits need squashing once review passes.

@zakkak is away so maybe @Karm or @jerboaa can review?

galderz · 2023-06-12T05:48:23Z

The JVM test failure is unrelated.

jerboaa

Seems OK to me.

gsmet

I added a suggestion and in any case could you squash the commits?

gsmet · 2023-06-20T16:53:45Z

core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java

@@ -198,6 +198,11 @@ public interface NativeConfig {
     */
    Optional<Boolean> containerBuild();

+    /**
+     * Explicit configuration option to generate PIE native binaries.


I'm not sure I understand when PIE will be enabled, especially when this is not set. I think we should make it more explicit in the doc.

zakkak

LGTM, other than the documentation part (see my suggestion)

zakkak · 2023-06-23T08:05:00Z

core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java

@@ -198,6 +198,11 @@ public interface NativeConfig {
     */
    Optional<Boolean> containerBuild();

+    /**
+     * Explicit configuration option to generate PIE native binaries.


I agree with @gsmet that a more explicit (and consistent with the rest) documentation is needed.

Suggested change

* Explicit configuration option to generate PIE native binaries.

* If this build should build a Position Independent Executable (PIE). Not setting the option results in using the

* underlying system's defaults.

galderz · 2023-06-27T04:43:49Z

@gsmet @zakkak I've pushed an update for the javadoc option. How does that sound now?

zakkak

I still don't find the doc clear enough. Added some suggestions.

zakkak · 2023-06-27T11:17:26Z

core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java

@@ -198,6 +198,15 @@ public interface NativeConfig {
     */
    Optional<Boolean> containerBuild();

+    /**
+     * Explicit configuration option to generate Position Independent Executable (PIE) native executables for Linux.
+     * If the system supports, the default behaviour is to generate native binaries without PIE for


If the system supports what?

I suggest:

Suggested change

* If the system supports, the default behaviour is to generate native binaries without PIE for

* If the system we are building on supports PIE generation, the default behaviour is to disable it

zakkak · 2023-06-27T11:18:54Z

core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java

@@ -198,6 +198,15 @@ public interface NativeConfig {
     */
    Optional<Boolean> containerBuild();

+    /**
+     * Explicit configuration option to generate Position Independent Executable (PIE) native executables for Linux.


Avoid redundant "executable":

Suggested change

* Explicit configuration option to generate Position Independent Executable (PIE) native executables for Linux.

* Explicit configuration option to generate a native Position Independent Executable (PIE) for Linux.

zakkak · 2023-06-27T11:21:11Z

core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java

+     * Some systems only support PIE executables,
+     * so this option offers the opportunity to generate native executables with PIE instead.


Avoid redundant "executable" and reduce words:

Suggested change

* Some systems only support PIE executables,

* so this option offers the opportunity to generate native executables with PIE instead.

* Some systems, however, only support platform independent executables (PIEs),

* this option enables the generation of such native executables.

Don't see the need to introduce again what is a PIE.

galderz · 2023-06-28T09:42:46Z

Pushed another round of updates for the PIE option javadoc.

zakkak

LGTM, thanks @galderz

galderz · 2023-06-28T16:39:26Z

Thx @zakkak. Squashed the commits and pushed.

galderz · 2023-07-21T07:53:04Z

Rebased to resolve conflict. Can someone integrate this?

quarkus-bot · 2023-07-21T14:11:54Z

Failing Jobs - Building `c83272a`

Status	Name	Step	Failures	Logs	Raw logs
✔️	Maven Tests - JDK 11
⌛	Maven Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs

zakkak · 2023-07-21T19:17:21Z

@galderz do you think it's worth backporting to 3.2?

galderz · 2023-07-24T07:15:09Z

@zakkak Yeah I think it's worth it. I'll send a PR for it.

galderz · 2023-07-24T07:19:33Z

See #34944 for the 3.2.x backport.

zakkak · 2023-07-24T07:26:21Z

See #34944 for the 3.2.x backport.

I added the triage/backport? label so that it doesn't get accidentally missed

galderz mentioned this pull request Jun 9, 2023

Native Executable --no-pie #33524

Closed

quarkus-bot bot added the area/core label Jun 9, 2023

This comment has been minimized.

Sign in to view

jerboaa approved these changes Jun 13, 2023

View reviewed changes

gsmet reviewed Jun 20, 2023

View reviewed changes

zakkak requested changes Jun 23, 2023

View reviewed changes

zakkak requested changes Jun 27, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

zakkak approved these changes Jun 28, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

galderz force-pushed the topic.0607.pie-flag branch from 680b1a0 to df25342 Compare June 28, 2023 16:38

This comment has been minimized.

Sign in to view

Add option to produce PIE native binaries quarkusio#33524

c83272a

galderz force-pushed the topic.0607.pie-flag branch from df25342 to c83272a Compare July 21, 2023 07:52

zakkak added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 21, 2023

zakkak merged commit 2da3206 into quarkusio:main Jul 21, 2023

quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jul 21, 2023

quarkus-bot bot added this to the 3.3 - main milestone Jul 21, 2023

zakkak mentioned this pull request Jul 24, 2023

Backport: Add option to produce PIE native binaries #34944

Merged

zakkak added the triage/backport? label Jul 24, 2023

zakkak removed the triage/backport? label Jul 25, 2023

galderz deleted the topic.0607.pie-flag branch December 19, 2023 05:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add optional native flag to build PIE binaries #33931

Add optional native flag to build PIE binaries #33931

galderz commented Jun 9, 2023

This comment has been minimized.

galderz commented Jun 12, 2023

jerboaa left a comment

gsmet left a comment

gsmet Jun 20, 2023

zakkak left a comment

zakkak Jun 23, 2023

galderz commented Jun 27, 2023

zakkak left a comment

zakkak Jun 27, 2023

zakkak Jun 27, 2023

zakkak Jun 27, 2023

galderz Jun 28, 2023

This comment has been minimized.

galderz commented Jun 28, 2023

zakkak left a comment

This comment has been minimized.

galderz commented Jun 28, 2023

This comment has been minimized.

galderz commented Jul 21, 2023

quarkus-bot bot commented Jul 21, 2023

zakkak commented Jul 21, 2023

galderz commented Jul 24, 2023

galderz commented Jul 24, 2023

zakkak commented Jul 24, 2023

	* Explicit configuration option to generate PIE native binaries.
	* If this build should build a Position Independent Executable (PIE). Not setting the option results in using the
	* underlying system's defaults.

	* If the system supports, the default behaviour is to generate native binaries without PIE for
	* If the system we are building on supports PIE generation, the default behaviour is to disable it

		* Some systems only support PIE executables,
		* so this option offers the opportunity to generate native executables with PIE instead.

Add optional native flag to build PIE binaries #33931

Add optional native flag to build PIE binaries #33931

Conversation

galderz commented Jun 9, 2023

This comment has been minimized.

galderz commented Jun 12, 2023

jerboaa left a comment

Choose a reason for hiding this comment

gsmet left a comment

Choose a reason for hiding this comment

gsmet Jun 20, 2023

Choose a reason for hiding this comment

zakkak left a comment

Choose a reason for hiding this comment

zakkak Jun 23, 2023

Choose a reason for hiding this comment

galderz commented Jun 27, 2023

zakkak left a comment

Choose a reason for hiding this comment

zakkak Jun 27, 2023

Choose a reason for hiding this comment

zakkak Jun 27, 2023

Choose a reason for hiding this comment

zakkak Jun 27, 2023

Choose a reason for hiding this comment

galderz Jun 28, 2023

Choose a reason for hiding this comment

This comment has been minimized.

galderz commented Jun 28, 2023

zakkak left a comment

Choose a reason for hiding this comment

This comment has been minimized.

galderz commented Jun 28, 2023

This comment has been minimized.

galderz commented Jul 21, 2023

quarkus-bot bot commented Jul 21, 2023

Failing Jobs - Building c83272a

zakkak commented Jul 21, 2023

galderz commented Jul 24, 2023

galderz commented Jul 24, 2023

zakkak commented Jul 24, 2023

Failing Jobs - Building `c83272a`