-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev UI Config NPE fix #33921
Dev UI Config NPE fix #33921
Conversation
Signed-off-by: Phillip Kruger <[email protected]>
Failing Jobs - Building 0dafe24
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
✖
⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
|
@@ -300,7 +301,7 @@ private List<ConfigDescription> calculate(List<ConfigDescription> cd, Set<String | |||
private ConfigValue getConfigValue(SmallRyeConfig config, String name) { | |||
try { | |||
return config.getConfigValue(name); | |||
} catch (java.util.NoSuchElementException nse) { | |||
} catch (NullPointerException | NoSuchElementException nse) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, is it the right fix? It's normal that we don't have a context set in this particular case?
/cc @radcortez
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check: #33884 (comment)
Fix #33884