Fix parameter validation issue in classic rest-client #33918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sgitario
requested changes
Jun 13, 2023
|
@Sgitario I added a test for rest-client-reactive as requested. Please take another look when you have a chance. |
This comment has been minimized.
This comment has been minimized.
Many thanks! You need to build the modules you changed using Maven, so the files get formatted, ( |
URL parsing inside of `QuarkusRestClientBuilder.verifyInterface` used
`ResteasyUriBuilderImpl.uri`, which works for most cases, but parsed in
subtly wrong ways when the constructed path started with `//`. For
example, a path of `//{id}` parses `{id}` as the hostname. Such a path
was possible to trigger by a couple of scenarios:
1. Interface has `@Path("")`, and a method-level `@Path` value starting
with `/`.
2. Interface has `@Path("/")`, and a method-level `@Path` value not
starting with `/`.
Furthermore, if the first path component contained a path param, then it
would not be counted, leading to incorrect validation results.
Added an empty path test to rest-client-reactive.
kahowell
force-pushed
the
resteasy-classic-pathparam-bugfix
branch
from
d0f6637 to
8c0e055
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sgitario
approved these changes
Jun 22, 2023
|
Great, many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL parsing inside of
QuarkusRestClientBuilder.verifyInterfaceusedResteasyUriBuilderImpl.uri, which works for most cases, but parsed in subtly wrong ways when the constructed path started with//. For example, a path of//{id}parses{id}as the hostname. Such a path was possible to trigger by a couple of scenarios:@Path(""), and a method-level@Pathvalue starting with/.@Path("/"), and a method-level@Pathvalue not starting with/.Furthermore, if the first path component contained a path param, then it would not be counted, leading to incorrect validation results.
Fixes: #33915