REST reactive: use ClientLogger bean, if present

[mickroll]

With org.jboss.resteasy.reactive.client.api.ClientLogger, there is already an api to implement a custom REST reactive client logger. For now, the only way to use it, is to set it while building org.jboss.resteasy.reactive.client.impl.ClientBuilderImpl manually. All other REST reactive clients fall back to using org.jboss.resteasy.reactive.client.logging.DefaultClientLogger.

This PR adds bean pickup logic: if a CDI bean for ClientLogger is found, it is used. Otherwise, use DefaultClientLogger.

As Arc is not a dependency in the org.jboss.resteasy.reactive.client context (and shouldn't be if i understand correctly), i added the pickup logic to io.quarkus.rest.client.reactive.runtime.RestClientBuilderImpl, which in turn uses ClientBuilderImpl.
But there is another place where ClientBuilderImpl is used: io.quarkus.keycloak.admin.client.reactive.runtime.ResteasyReactiveClientProvider. So i added the pickup logic there as well.

The solution was discussed here: #33332

cc @michalvavrik, @geoand

[quarkus-bot]

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

• title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

[geoand]

cc @Sgitario

[Sgitario]

I would add a simple test case that ensures this works when:

• Injecting the REST Client via @RestClient
• Programmatically using QuarkusRestClientBuilderImpl
• Programmatically using RestClientBuilderImpl

[github-actions]

🙈 The PR is closed and the preview is expired.

[mickroll]

(sorry for all the force pushes. i currently don't have a working local dev environment for quarkus and the builds in my github codespace keep dying with exit code 143, suspected SIGTERM)

[mickroll]

I would add a simple test case that ensures this works when:
* Injecting the REST Client via @RestClient
* Programmatically using QuarkusRestClientBuilderImpl
* Programmatically using RestClientBuilderImpl

@Sgitario I added both a test using @RestClient and a test using QuarkusRestClientBuilderImpl. The latter internally delegates to RestClientBuilderImpl so i did not write an extra test for that. I tried to keep close to how ResponseExceptionMapper is tested.

[Sgitario]

I would add a simple test case that ensures this works when:

• Injecting the REST Client via @RestClient
• Programmatically using QuarkusRestClientBuilderImpl
• Programmatically using RestClientBuilderImpl

@Sgitario I added both a test using @RestClient and a test using QuarkusRestClientBuilderImpl. The latter internally delegates to RestClientBuilderImpl so i did not write an extra test for that. I tried to keep close to how ResponseExceptionMapper is tested.

Please, be sure you build the modules you have modified using the Maven command before pushing the commit to avoid formatting issues. For example, running mvn clean install -Dquickly would do it.

Also, the linting issue with the documentation still stands.

[mickroll]

Sorry for the push-mess in this PR.
I have finally managed to setup a local dev environment.

For the doc linting issue: I added "TIP: " in front of it and followed the recommendation to replace "via" with "through". The Documentation CI build is successful. Or am i missing something else there?

[quarkus-bot]

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

[Sgitario]

@michalvavrik do you want to take another look before merging this one?

[michalvavrik]

thanks @Sgitario , keycloak-admin-client-reactive part LGTM

[mickroll]

Thanks for your patience, @Sgitario and @michalvavrik

[Sgitario]

Thanks for your patience, @Sgitario and @michalvavrik

Thanks to you for your work!