-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Jackson to 2.15.2 #33762
Bump Jackson to 2.15.2 #33762
Conversation
pom.xml
Outdated
<maven.compiler.target>17</maven.compiler.target> | ||
<maven.compiler.source>17</maven.compiler.source> | ||
<maven.compiler.release>17</maven.compiler.release> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely don't want this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to get my Test using "record" running. Is there another way to enable Java version with "record"??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say let's remove the test altogether as it's not a Quarkus issue, it's a Jackson issue so we should not be testing for it (unless we have some problematic integration point)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a plan to update the maven.compiler settings to a newer version than 11?
So far i will remove the Test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a plan to update the maven.compiler settings to a newer version than 11?
No.
But for Java 17 specific things, we do have a dedicated integration test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, where can i find these dedicated Tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it’s a Jackson bug, I don’t think we need a test in our code base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, than next time we need to check again manually...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we were to add such tests, we would need to add them for every feature under the sun, that just isn't practical.
What we do test extensively is our integration points with the various libraries and our workarounds for known problems.
The Jackson problem you linked to is neither - but of course we do want to bump to the latest Jackson version.
Thanks for the contribution! Please rebase the PR onto |
Thanks but this was incomplete. I created #33846 and kept your commit and authorship in there. |
In Jackson 2.15.2 the following Issue was fixed:
FasterXML/jackson-databind#3895
Added Test for Jackson 2.15.2 Issue.