Configurable strategy to control GraalVM build image pulling #33749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
approved these changes
May 31, 2023
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
yrodiere
added a commit
to yrodiere/quarkus
that referenced
this pull request
Jun 1, 2023
Follows up on quarkusio#33749. I forgot to remove this code that was just a remainder of an earlier approach which didn't go anywhere (quarkusio#33691 (comment)). Keeping this code could in theory lead to extra pulls when using quarkus.native.build-image.pull='always' (the default) and the image gets updated right while we're building, but more importantly it could lead to extra, unecessary queries to quay.io, so let's avoid that.
sberyozkin
pushed a commit
to sberyozkin/quarkus
that referenced
this pull request
Jun 21, 2023
Follows up on quarkusio#33749. I forgot to remove this code that was just a remainder of an earlier approach which didn't go anywhere (quarkusio#33691 (comment)). Keeping this code could in theory lead to extra pulls when using quarkus.native.build-image.pull='always' (the default) and the image gets updated right while we're building, but more importantly it could lead to extra, unecessary queries to quay.io, so let's avoid that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33691
With this patch, you can set the environment variable
QUARKUS_NATIVE_BUILDER_IMAGE_PULLto e.g.missing, and Quarkus will only ever pull the image if it's not available in the local docker/podman registry.I'd appreciate if someone could test with podman as I don't have it locally, and from what I understand CI does not run against podman (yet).
I tested locally with the Hibernate ORM quickstart: