Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't strip stack trace on startup failures #33731

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented May 31, 2023

Resolves: #32763

From what I see in the source of ApplicationLifecycleManager we detect the root cause to check if its:

  • PreventFurtherStepException
  • ConfigurationException
  • etc

However, we should use the original exception for logging, so that the context is not stripped and the error message makes sense. This PR does that.

@iocanel iocanel requested a review from geoand May 31, 2023 13:13
@geoand
Copy link
Contributor

geoand commented May 31, 2023

Seems reasonable, but I want to give it a spin

@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Jun 1, 2023

The test failure is suspicious...

@iocanel iocanel force-pushed the fix-32763-kube-config-err branch from 20e0ee0 to 700e37b Compare June 1, 2023 08:30
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 2, 2023

Failing Jobs - Building 700e37b

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 19
Native Tests - Amazon Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: devtools/gradle/gradle-model 
! Skipped: devtools/gradle/gradle-application-plugin devtools/gradle/gradle-extension-plugin 

📦 devtools/gradle/gradle-model

Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (gradle) on project quarkus-gradle-model: Command execution failed.


⚙️ Native Tests - Amazon #

- Failing: integration-tests/amazon-lambda integration-tests/amazon-lambda-http 

📦 integration-tests/amazon-lambda

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleIT.testSimpleLambdaSuccess - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.amazon.lambda.deployment.DevServicesLambdaProcessor#startEventServer threw an exception: java.lang.RuntimeException: java.util.concurrent.ExecutionException: java.net.BindException: Address already in use

📦 integration-tests/amazon-lambda-http

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleIT.testJaxrsCognitoJWTSecurityContext - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.amazon.lambda.deployment.DevServicesLambdaProcessor#startEventServer threw an exception: java.lang.RuntimeException: java.util.concurrent.ExecutionException: java.net.BindException: Address already in use

@gsmet gsmet merged commit b2a1f29 into quarkusio:main Jun 6, 2023
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jun 6, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a warn/error when kubernetes-config can't read target resource.
3 participants