-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArC: update CDI documentation with references to CDI 4.0 and CDI Lite #33719
Conversation
🙈 The PR is closed and the preview is expired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments in the PR, thanks for looking into this.
@@ -279,7 +280,7 @@ void doSomethingWithNamedBeans(SynthesisFinishedBuildItem synthesisFinished, Bui | |||
Sometimes it is practical to be able to register a _synthetic bean_. | |||
Bean attributes of a synthetic bean are not derived from a Java class, method or field. | |||
Instead, all the attributes are defined by an extension. | |||
In regular CDI, this could be achieved using the https://jakarta.ee/specifications/cdi/2.0/cdi-spec-2.0.html#after_bean_discovery[`AfterBeanDiscovery.addBean()`, window="_blank"] methods. | |||
In regular CDI, this could be achieved using the https://jakarta.ee/specifications/cdi/4.0/jakarta-cdi-spec-4.0.html#after_bean_discovery[`AfterBeanDiscovery.addBean()`, window="_blank"] methods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly to my comment above, maybe we want to relate this to Lite API rather than Full? Or perhaps mention both 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Note that we only point to Portable Extensions (and with this PR also Build Compatible Extensions) on 2 places, so we could perhaps just delete these references altogether. (Alternatively, we could point to corresponding PExtensions / BCExtensions APIs on all appropriate places?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do that as well.
Maybe it would be more beneficial to note what's the difference between using CDI API and Quarkus API. I.e. the ability to simply tweak just CDI parts versus the ability to perform deep and complex integration with basically any other Quarkus extension?
ee0576b
to
bfe7ce1
Compare
Related to #28558