Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArC: update CDI documentation with references to CDI 4.0 and CDI Lite #33719

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented May 31, 2023

Related to #28558

@github-actions
Copy link

github-actions bot commented May 31, 2023

🙈 The PR is closed and the preview is expired.

Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments in the PR, thanks for looking into this.

docs/src/main/asciidoc/cdi-integration.adoc Show resolved Hide resolved
docs/src/main/asciidoc/cdi-integration.adoc Outdated Show resolved Hide resolved
@@ -279,7 +280,7 @@ void doSomethingWithNamedBeans(SynthesisFinishedBuildItem synthesisFinished, Bui
Sometimes it is practical to be able to register a _synthetic bean_.
Bean attributes of a synthetic bean are not derived from a Java class, method or field.
Instead, all the attributes are defined by an extension.
In regular CDI, this could be achieved using the https://jakarta.ee/specifications/cdi/2.0/cdi-spec-2.0.html#after_bean_discovery[`AfterBeanDiscovery.addBean()`, window="_blank"] methods.
In regular CDI, this could be achieved using the https://jakarta.ee/specifications/cdi/4.0/jakarta-cdi-spec-4.0.html#after_bean_discovery[`AfterBeanDiscovery.addBean()`, window="_blank"] methods.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly to my comment above, maybe we want to relate this to Lite API rather than Full? Or perhaps mention both 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Note that we only point to Portable Extensions (and with this PR also Build Compatible Extensions) on 2 places, so we could perhaps just delete these references altogether. (Alternatively, we could point to corresponding PExtensions / BCExtensions APIs on all appropriate places?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do that as well.
Maybe it would be more beneficial to note what's the difference between using CDI API and Quarkus API. I.e. the ability to simply tweak just CDI parts versus the ability to perform deep and complex integration with basically any other Quarkus extension?

docs/src/main/asciidoc/cdi-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/cdi-reference.adoc Outdated Show resolved Hide resolved
@Ladicek Ladicek force-pushed the cdi-4.0-compatibility-docs branch from ee0576b to bfe7ce1 Compare May 31, 2023 10:22
@Ladicek Ladicek merged commit c64c7bf into quarkusio:main Jun 1, 2023
@Ladicek Ladicek deleted the cdi-4.0-compatibility-docs branch June 1, 2023 12:49
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants