Dev UI: Add source editor for configuration #33661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillip-kruger
force-pushed
the
dev-ui-config-editor
branch
from
d4112f6 to
731926e
Compare
cescoffier
requested changes
May 29, 2023
...s/vertx-http/runtime/src/main/java/io/quarkus/devui/runtime/config/ConfigJsonRPCService.java
Outdated
Show resolved
Hide resolved
phillip-kruger
force-pushed
the
dev-ui-config-editor
branch
from
731926e to
2ef9975
Compare
phillip-kruger
changed the title
cescoffier
approved these changes
May 29, 2023
phillip-kruger
force-pushed
the
dev-ui-config-editor
branch
2 times, most recently
from
249ec4b to
329058d
Compare
Signed-off-by: Phillip Kruger <[email protected]>
phillip-kruger
force-pushed
the
dev-ui-config-editor
branch
from
a6a8684 to
3530508
Compare
phillip-kruger
added
the
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@gsmet @cescoffier The CI error seems unrelated and I can build this on my laptop. Are we ok to merge ? |
Failing Jobs - Building 3530508
Full information is available in the Build summary check run. Failures⚙️ Native Tests - Amazon #- Failing: integration-tests/amazon-lambda-http
📦 integration-tests/amazon-lambda-http✖ |
cescoffier
approved these changes
Jun 5, 2023
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be rebased on #33660 - thus draft for now.
This implements the config editor: