-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add links to Well-Known OIDC providers doc #33641
Add links to Well-Known OIDC providers doc #33641
Conversation
🙈 The PR is closed and the preview is expired. |
Hey @michelle-purcell @sheilamjones I think simplest would be to add provider tags to the website, I'll follow up with another PR later |
Hi @sberyozkin, |
Hi @sheilamjones Np at all, take your time please, I'll be signing off shortly for the evening, back tomorrow morning, thanks |
docs/src/main/asciidoc/security-authentication-mechanisms-concept.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-concept.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to add a mention and reference for the following topic to the Quarkus Security overview page:
xref:security-openid-connect-providers.adoc[Configuring Well-Known OpenID Connect Providers]
For example here/References link section:
@sberyozkin - Looks great 👍 Super job. See my comments above. Thanks. |
docs/src/main/asciidoc/security-authentication-mechanisms-concept.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-concept.adoc
Outdated
Show resolved
Hide resolved
Thanks @sberyozkin for making these updates. They look great and also had a few small additional comments. With regards to the title of the existing [Configuring Well-Known OpenID Connect Providers] guide, would it be possible to update the title of the guide itself in this PR also to change it to sentence case, that is, "Configuring well-known OpenID Connect providers" or ""Configuring commonly-used OpenID Connect providers" if you choose that alternative term? |
618aa6e
to
5cdee63
Compare
Hey @michelle-purcell @sheilamjones |
If well-known is a well-known security term (:wink: ) familiar to Java developers who want to use/start using Quarkus then let's keep it. @sheilamjones ? |
docs/src/main/asciidoc/security-authentication-mechanisms-concept.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-concept.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
Thanks for your updates @sberyozkin. And I am fine to keep "well-known" then too in this context. I just had a couple of additional minor comments for your consideration. Thank you :) |
Hey @michelle-purcell |
5cdee63
to
13f3a93
Compare
Thanks @sheilamjones, done. @sheilamjones @michelle-purcell thanks for a great review 👍 , very welcome, security docs can only become better after your reviews :-) |
Thanks @gastaldi |
Fixes #33056.
Hi @michelle-purcell @sheilamjones, it is an attempt to make the Well Known Providers doc more visible from within OIDC specific docs and sections, I've added extra links from the authentication mechanism concept doc, in the OIDC code flow concept and tutorials, and along the way updated the reference links section on the code flow tutorial (non-Quarkus doc links moved to the very end, minor optimization in the
Summary
section).Have a look please.
The plan is to follow up with adding tags like
google
,github
etc in the website for the users to immediately find the Well Known Providers doc if they type for exampletwitter
in theSearch
area.Do you think though if we can also add such tags to the Well Known Providers doc itself with this PR ?
Thanks