Dev UI fixes #33620

phillip-kruger · 2023-05-26T01:22:48Z

@rsvoboda please can you test and let me know.

Fix #29422
Fix #33587
Fix #32926
Fix #33588

Also added config filter for datasource extension, and hide the config filter button on a extension card, if that extension did not define any filter properties.

Signed-off-by: Phillip Kruger <[email protected]>

quarkus-bot · 2023-05-26T06:26:00Z

Failing Jobs - Building `4750976`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 19	`Build`	Failures	Logs	Raw logs
⌛	Maven Tests - JDK 11	`Build`	Failures	Logs	Raw logs
⌛	Maven Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/flyway/deployment extensions/oidc/deployment 
! Skipped: extensions/keycloak-admin-client-reactive/deployment extensions/keycloak-admin-client/deployment extensions/keycloak-authorization/deployment and 25 more

📦 extensions/flyway/deployment

✖ io.quarkus.flyway.test.FlywayDevModeCreateFromHibernateTest.testGenerateMigrationFromHibernate line 39 - More details - Source on GitHub

org.apache.http.NoHttpResponseException: localhost:8080 failed to respond
	at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:141)
	at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:56)

📦 extensions/oidc/deployment

✖ io.quarkus.oidc.test.CodeFlowDevModeDefaultTenantTestCase.testAccessAndRefreshTokenInjectionDevMode - More details - Source on GitHub

java.lang.RuntimeException: 
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.devui.deployment.menu.ConfigurationProcessor#createConfigurationPages threw an exception: java.util.NoSuchElementException

✖ io.quarkus.oidc.test.CodeFlowDevModeTestCase.testAccessAndRefreshTokenInjectionDevMode - More details - Source on GitHub

java.lang.RuntimeException: 
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.devui.deployment.menu.ConfigurationProcessor#createConfigurationPages threw an exception: java.util.NoSuchElementException

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/flyway/deployment extensions/oidc/deployment 
! Skipped: extensions/keycloak-admin-client-reactive/deployment extensions/keycloak-admin-client/deployment extensions/keycloak-authorization/deployment and 25 more

📦 extensions/flyway/deployment

✖ io.quarkus.flyway.test.FlywayDevModeCreateFromHibernateTest.testGenerateMigrationFromHibernate line 39 - More details - Source on GitHub

org.apache.http.NoHttpResponseException: localhost:8080 failed to respond
	at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:141)
	at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:56)

📦 extensions/oidc/deployment

✖ io.quarkus.oidc.test.CodeFlowDevModeDefaultTenantTestCase.testAccessAndRefreshTokenInjectionDevMode - More details - Source on GitHub

java.lang.RuntimeException: 
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.devui.deployment.menu.ConfigurationProcessor#createConfigurationPages threw an exception: java.util.NoSuchElementException

✖ io.quarkus.oidc.test.CodeFlowDevModeTestCase.testAccessAndRefreshTokenInjectionDevMode - More details - Source on GitHub

java.lang.RuntimeException: 
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.devui.deployment.menu.ConfigurationProcessor#createConfigurationPages threw an exception: java.util.NoSuchElementException

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/flyway/deployment 
! Skipped: integration-tests/flyway integration-tests/hibernate-orm-compatibility-5.6/mariadb integration-tests/hibernate-orm-compatibility-5.6/postgresql and 4 more

📦 extensions/flyway/deployment

✖ io.quarkus.flyway.test.FlywayDevModeCreateFromHibernateTest.testGenerateMigrationFromHibernate line 39 - More details - Source on GitHub

org.apache.http.NoHttpResponseException: localhost:8080 failed to respond
	at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:141)
	at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:56)

⚙️ JVM Tests - JDK 19 #

- Failing: extensions/flyway/deployment extensions/oidc/deployment 
! Skipped: extensions/keycloak-admin-client-reactive/deployment extensions/keycloak-admin-client/deployment extensions/keycloak-authorization/deployment and 25 more

📦 extensions/flyway/deployment

✖ io.quarkus.flyway.test.FlywayDevModeCreateFromHibernateTest.testGenerateMigrationFromHibernate line 39 - More details - Source on GitHub

org.apache.http.NoHttpResponseException: localhost:8080 failed to respond
	at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:141)
	at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:56)

📦 extensions/oidc/deployment

✖ io.quarkus.oidc.test.CodeFlowDevModeDefaultTenantTestCase.testAccessAndRefreshTokenInjectionDevMode - More details - Source on GitHub

java.lang.RuntimeException: 
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.devui.deployment.menu.ConfigurationProcessor#createConfigurationPages threw an exception: java.util.NoSuchElementException

✖ io.quarkus.oidc.test.CodeFlowDevModeTestCase.testAccessAndRefreshTokenInjectionDevMode - More details - Source on GitHub

java.lang.RuntimeException: 
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.devui.deployment.menu.ConfigurationProcessor#createConfigurationPages threw an exception: java.util.NoSuchElementException

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatApplicationRecoversCompilationIssue line 165 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatApplicationRecoversCompilationIssue(RemoteDevMojoIT.java:165)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnNewResource line 67 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnNewResource(RemoteDevMojoIT.java:67)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatNewBeanAreDiscovered line 202 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatNewBeanAreDiscovered(RemoteDevMojoIT.java:202)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange line 99 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange(RemoteDevMojoIT.java:99)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnJavaChange line 34 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnJavaChange(RemoteDevMojoIT.java:34)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatApplicationRecoversCompilationIssue line 165 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatApplicationRecoversCompilationIssue(RemoteDevMojoIT.java:165)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnNewResource line 67 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnNewResource(RemoteDevMojoIT.java:67)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatNewBeanAreDiscovered line 202 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatNewBeanAreDiscovered(RemoteDevMojoIT.java:202)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange line 99 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange(RemoteDevMojoIT.java:99)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnJavaChange line 34 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnJavaChange(RemoteDevMojoIT.java:34)

gsmet · 2023-05-26T07:49:45Z

At least some of the CI failures are related.

sberyozkin · 2023-05-26T10:22:20Z

Thanks @phillip-kruger, are all the updates in this PR backportable to the 3.0 and 3.1 branches ? If not then it can make sense to create a dedicated PR for the bits which have to be backported, sorry if the whole PR would be ready to be backported.

The actual change LGTM, thanks, lets see what QE says :-).

Build step io.quarkus.devui.deployment.menu.ConfigurationProcessor#createConfigurationPages threw an exception: java.util.NoSuchElementException

Probably because OIDC is still on the old Dev UI, it is getting closer though.

sberyozkin · 2023-05-26T10:23:36Z

@phillip-kruger Sorry, you have individual commits here, cool, thanks

phillip-kruger · 2023-05-26T10:29:58Z

Yes individual commits, but also all is back-portable. Just looking at the CI failures, as try seem related... Thanks :)

phillip-kruger · 2023-05-28T23:38:49Z

I'll do two PRs to do the CORS stuff separate

phillip-kruger requested review from cescoffier, sberyozkin, rsvoboda and gsmet May 26, 2023 01:22

quarkus-bot bot added the area/vertx label May 26, 2023

phillip-kruger added 4 commits May 26, 2023 11:25

Add DevConsoleCORSFilter to Dev UI JsonRPC WebSocket

3e80dcd

Signed-off-by: Phillip Kruger <[email protected]>

Dev UI fix error in log on Hot Reload when properties change

500a2ea

Signed-off-by: Phillip Kruger <[email protected]>

Dev UI Make sure user config is added to editor

1b24261

Signed-off-by: Phillip Kruger <[email protected]>

Do not show config filter if no filter exist

4750976

Signed-off-by: Phillip Kruger <[email protected]>

phillip-kruger force-pushed the dev-ui-fixes branch from e4e0e81 to 4750976 Compare May 26, 2023 01:25

melloware approved these changes May 27, 2023

View reviewed changes

phillip-kruger closed this May 28, 2023

quarkus-bot bot added the triage/invalid This doesn't seem right label May 28, 2023

phillip-kruger deleted the dev-ui-fixes branch June 13, 2023 04:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev UI fixes #33620

Dev UI fixes #33620

phillip-kruger commented May 26, 2023 •

edited

Loading

quarkus-bot bot commented May 26, 2023

gsmet commented May 26, 2023

sberyozkin commented May 26, 2023

sberyozkin commented May 26, 2023

phillip-kruger commented May 26, 2023

phillip-kruger commented May 28, 2023

Dev UI fixes #33620

Dev UI fixes #33620

Conversation

phillip-kruger commented May 26, 2023 • edited Loading

quarkus-bot bot commented May 26, 2023

Failing Jobs - Building 4750976

Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/flyway/deployment

📦 extensions/oidc/deployment

⚙️ JVM Tests - JDK 17 #

📦 extensions/flyway/deployment

📦 extensions/oidc/deployment

⚙️ JVM Tests - JDK 17 Windows #

📦 extensions/flyway/deployment

⚙️ JVM Tests - JDK 19 #

📦 extensions/flyway/deployment

📦 extensions/oidc/deployment

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

gsmet commented May 26, 2023

sberyozkin commented May 26, 2023

sberyozkin commented May 26, 2023

phillip-kruger commented May 26, 2023

phillip-kruger commented May 28, 2023

phillip-kruger commented May 26, 2023 •

edited

Loading

Failing Jobs - Building `4750976`