Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parent structure regarding updating the version with the versions plugin #33571

Merged
merged 2 commits into from
May 24, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented May 24, 2023

Fast tracking it as I can't release otherwise.

@gsmet gsmet merged commit 071a89c into quarkusio:main May 24, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone May 24, 2023
@gsmet
Copy link
Member Author

gsmet commented May 24, 2023

@gastaldi FYI when you're back.

@@ -36,6 +36,7 @@
<version.shade.plugin>3.4.1</version.shade.plugin>
<version.source.plugin>3.2.1</version.source.plugin>
<version.surefire.plugin>${version.failsafe.plugin}</version.surefire.plugin>
<version.versions.plugin>2.15.0</version.versions.plugin>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this might have fixed it as I saw similar reports for older versions but it didn't. Kept it anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants