Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid null pointer exception when resolving generics in RR #33568

Merged
merged 1 commit into from
May 24, 2023

Conversation

Sgitario
Copy link
Contributor

This pull request does not provide support for generics when using sub resources, but avoid giving a null pointer exception. I found this issue when looking at #30127.

This pull request does not provide support for generics when using sub resources, but avoid giving a null pointer exception.
I found this issue when looking at quarkusio#30127.
@Sgitario Sgitario requested a review from geoand May 24, 2023 05:03
@quarkus-bot
Copy link

quarkus-bot bot commented May 24, 2023

Failing Jobs - Building 94c8dd3

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 19

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/cache/deployment 
! Skipped: extensions/csrf-reactive/deployment extensions/qute/deployment extensions/redis-cache/deployment and 7 more

📦 extensions/cache/deployment

io.quarkus.cache.test.runtime.ConcurrencyTest.testConcurrentCacheAccessWithLockTimeout line 67 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: not equal but was: <pool-48-thread-1>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:152)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

@Sgitario
Copy link
Contributor Author

I think the test failures are unrelated. Merging.

@Sgitario Sgitario merged commit 574ed4e into quarkusio:main May 24, 2023
@Sgitario Sgitario deleted the avoid_npe_generics branch May 24, 2023 13:16
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants