X will open editor on current working directory as a fallback #33529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Would it not be more clean to have it as a separate option? |
|
so grap 'e' to open editor on current project? or maybe shift+X ? to not grab more letters than necessary? |
stuartwdouglas
approved these changes
May 22, 2023
|
I like it. There are a limited number of shortcuts we can provide, so I am fine with overriding them like this. |
|
🆗 |
|
This needs a formatting fix (the exact command to run is in the error message) |
|
I force pushed a fix for the formatting issue. |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #33060
realized we already have the mechanics to open IDE's thus why not have it open on default project if no exceptions found/recorded yet?
@geoand @stuartwdouglas wdyt?