-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linux podman build to CI #33464
Add Linux podman build to CI #33464
Conversation
/cc @Sanne (hibernate-orm), @brunobat (micrometer), @ebullient (micrometer), @gsmet (hibernate-orm), @yrodiere (hibernate-orm) |
This comment has been minimized.
This comment has been minimized.
Oh rats, the report for my new workflow is still failing when run in the main build. I assumed it was just failing because I'd been testing in a fork.
I'll remove that step and we can work on figuring out why it's not working. |
This comment has been minimized.
This comment has been minimized.
299813d
to
4e11f22
Compare
I've removed the PR-trigger for the podman build, so the build of this PR should be very boring, but I believe this change is now ready to merge. We need native testing, but I will do that as a follow-on work item. I've spoken with @gsmet, and we've agreed that the workflow file is rather large, which creates a maintenance burden. Longer term, it will be better to include podman in the regular matrix build. We don't want to exercise podman every PR, but we can do some tricks with the schedule and the matrix calculation. For example, if the schedule time matches a magic number, the matrix calculation will include podman. This scales better as we increase our podman coverage to mac, windows, etc. It means podman build results will be mixed in with the main CI results, which has advantages (one place to look, less clutter of workflows) and disadvantages (confusing if something fails). The matrix calculation should be straightforward for JVM, and slightly harder for native, but we can get there. Here's what a trigger-test might look like
|
@holly-cummins FWIW, you might be able to use |
I've added a workflow to give us some coverage of podman on Linux. I've set it up to run on a schedule, rather than every PR or push.
Notes: In my first revision, I have the build triggering on PRs, so we can see it running. I'll remove those stanzas before merging. I do have a build which ran clean on my fork apart from permissions failures on the report upload.
I've been running this build on my own fork, and observed a number of failures. Most (all?) are not reproducible on local linux, and seem to be related to GitHub Actions virtualisation. I've disabled the tests in this PR, and raised issues. https://github.com/quarkusio/quarkus/issues?q=is%3Aissue+is%3Aopen+label%3Aenv%2Fpodman is the most convenient way to see a list of the issues (if you ignore ones raised by other people).
We're seeing issues building podman native, so I will also add some runs for that in a follow-on PR, but I wanted to get the JVM tests running first.