Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OIDC Spotify properties #33442

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented May 17, 2023

This PR makes it a bit easier to use Spotify provider:

  • User name can now be extracted from the injected UserInfo as userInfo.getDisplayName()
  • For the above to work, another scope user_read_private is added (it is like profile scope we add to Github/Google/etc provider definitions - it won't go unnoticed by the users, Spotify authorization screen will let them know), and also a principal claim name is customized as display_name (Spotify specific claim name)

Also, an access token is binary so to verify it one would need to fetch UserInfo (so a property is added to the provider definition, same as we do for other social providers producing binary tokens) and a minor update is done to the deployment code for Provider: Spotify link to appear in Dev UI OIDC card

@sberyozkin sberyozkin requested a review from gastaldi May 17, 2023 12:10
@quarkus-bot
Copy link

quarkus-bot bot commented May 17, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin sberyozkin merged commit 51c7d6d into quarkusio:main May 30, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone May 30, 2023
@sberyozkin sberyozkin deleted the oidc_spotify branch May 30, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants