Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.13: Encrypt OIDC session cookie value by default #33414

Merged
merged 3 commits into from
May 23, 2023

Conversation

sberyozkin
Copy link
Member

No description provided.

@sberyozkin sberyozkin requested a review from gsmet May 16, 2023 14:21
@quarkus-bot

This comment has been minimized.

@quarkus-bot quarkus-bot bot added area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/oidc labels May 17, 2023
@gsmet gsmet added this to the 2.13.8.Final milestone May 17, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented May 17, 2023

Failing Jobs - Building a56acfe

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.AvroDevModeTest.main line 15 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.ConditionalDependenciesTest.scenarioTwo line 147 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting path:

io.quarkus.gradle.devmode.KotlinProjectWithCompilerArgsDevModeTest.main line 17 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discussed with @rsvoboda and we will merge it. Thanks!

@gsmet gsmet merged commit 8d16ce1 into quarkusio:2.13 May 23, 2023
@sberyozkin sberyozkin deleted the session_cookie_encrypt_2.13 branch September 6, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/oidc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants