-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the generation init-tasks by database migration on Kubernetes/OpenShift #33409
Conversation
This comment has been minimized.
This comment has been minimized.
It seems that |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -20,40 +21,47 @@ | |||
|
|||
public class InitTaskProcessor { | |||
|
|||
private static final String INIT_CONTAINER_WAITER_NAME = "init"; | |||
private static final String INIT_CONTAINER_WAITER_DEFAULT_IMAGE = "groundnuty/k8s-wait-for:no-root-v1.7"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we used it before your patch but I didn't notice it. Are we sure using this image is safe? I'm a bit worried about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never heard about it.... We need to have a deeper look.
The fact that it uses Alpine is not a great start...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this image seems to be commonly used by the community for this purpose and also it was already used before these changes, I think the way to proceed is to open a new issue to investigate how secure it is and the alternatives.
@cescoffier @gsmet @iocanel do you think we can merge these changes that improve this existing feature or do you prefer put it hold off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't hold off this pull request because of the image. We need to track it in a separate issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What image was used before ? Yeah. We should not be using/proposing alpine unless absolutely no other option.
What is the requirements for the image and why not use the base images we otherwise use here ? (That would mean 0 mb extra to fetch :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added an optional suggestion. Which can be part of this or a follow up request.
Regarding the image, I think that it needs to be tracked / addressed by a different issue / pr.
...etes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesConfig.java
Outdated
Show resolved
Hide resolved
To groundnuty/k8s-wait-for:no-root-v1.7. Related to quarkusio#33097 (comment)
Failing Jobs - Building f982d5e
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 Windows #- Failing: integration-tests/rest-client-reactive
📦 integration-tests/rest-client-reactive✖
|
The test failure is unrelated. Merging. |
This pull request includes the following changes:
groundnuty/k8s-wait-for:no-root-v1.7
which is compatible with OpenShift because it's rootlessFix #33097