Present more useful exception when QuarkusTestResourceLifecycleManager fails #33374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sgitario
requested changes
May 15, 2023
test-framework/derby/src/main/java/io/quarkus/test/derby/DerbyDatabaseTestResource.java
Outdated
Show resolved
Hide resolved
Sgitario
approved these changes
May 15, 2023
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
|
I'm a bit confused about how this is supposed to fix that NPE I reported in #33371? Are we assuming it's not thrown in Q3? PS: I would love to test-drive this PR, but blaze-persistence prevents me from upgrading. I could probably backport it locally though... 🤔 |
|
@famod I did the same thing you did but never got the NPE, so yeah, I am assuming it doesn't happen anymore with Quarkus 3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #33371
P.S. I didn't see the same stacktrace as #33371, but that's probably because that is using Quarkus 2.x