Use the container-provided settings decrypter

[dmlloyd]

Fixes #33220. At least, it might, but I can't seem to make the reproducer work.

[dmlloyd]

(Update: This issue is now resolved. See below.)

The bootstrap tests fail with this error:

[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.073 s <<< FAILURE! - in io.quarkus.bootstrap.resolver.maven.test.ProxyNoMirrorSettingsReposTest
[ERROR] io.quarkus.bootstrap.resolver.maven.test.ProxyNoMirrorSettingsReposTest.basicPomRepos  Time elapsed: 0.066 s  <<< ERROR!
io.smallrye.beanbag.NoSuchBeanException: No matching bean available: type is interface org.apache.maven.settings.crypto.SettingsDecrypter
	at io.smallrye.beanbag.Scope.getBean(Scope.java:256)
	at io.smallrye.beanbag.Scope.requireBean(Scope.java:161)
	at io.smallrye.beanbag.BeanBag.requireBean(BeanBag.java:80)
	at io.quarkus.bootstrap.resolver.maven.BootstrapMavenContext.initRepoSystemAndManager(BootstrapMavenContext.java:772)
	at io.quarkus.bootstrap.resolver.maven.BootstrapMavenContext.newRepositorySystem(BootstrapMavenContext.java:749)
	at io.quarkus.bootstrap.resolver.maven.BootstrapMavenContext.getRepositorySystem(BootstrapMavenContext.java:262)
	at io.quarkus.bootstrap.resolver.maven.BootstrapMavenContext.newResolutionRepos(BootstrapMavenContext.java:568)
	at io.quarkus.bootstrap.resolver.maven.BootstrapMavenContext.resolveRemoteRepos(BootstrapMavenContext.java:538)
	at io.quarkus.bootstrap.resolver.maven.BootstrapMavenContext.getRemoteRepositories(BootstrapMavenContext.java:274)
	at io.quarkus.bootstrap.resolver.maven.test.ProxyNoMirrorSettingsReposTest.basicPomRepos(ProxyNoMirrorSettingsReposTest.java:20)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:727)
        <...junit...>
        at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
	at org.apache.maven.surefire.junitplatform.LazyLauncher.execute(LazyLauncher.java:50)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.execute(JUnitPlatformProvider.java:184)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:148)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:122)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495)
	Suppressed: io.smallrye.beanbag.BeanInstantiationException: Failed to inject argument 0 of constructor for class org.apache.maven.settings.crypto.DefaultSettingsDecrypter
		at io.smallrye.beanbag.Bean$Failed.get(Bean.java:76)
		at io.smallrye.beanbag.Bean$Pending.get(Bean.java:122)
		at io.smallrye.beanbag.Bean.get(Bean.java:41)
		at io.smallrye.beanbag.Scope.getBean(Scope.java:234)
		... 80 more
	Caused by: io.smallrye.beanbag.BeanInstantiationException: Failed to inject argument 0 of constructor for class org.apache.maven.settings.crypto.DefaultSettingsDecrypter
		at io.smallrye.beanbag.ConstructorSupplier.get(ConstructorSupplier.java:30)
		at io.smallrye.beanbag.Bean$Pending.get(Bean.java:118)
		... 82 more
	Caused by: io.smallrye.beanbag.NoSuchBeanException: No matching bean available: type is interface org.sonatype.plexus.components.sec.dispatcher.SecDispatcher, name is "maven"
		at io.smallrye.beanbag.Scope.getBean(Scope.java:256)
		at io.smallrye.beanbag.BeanResolver.get(BeanResolver.java:20)
		at io.smallrye.beanbag.ConstructorSupplier.get(ConstructorSupplier.java:27)
		... 83 more

The problem is that there is in fact a bean provider for SecDispatcher named maven available from maven-settings-builder, but it's not being found by BeanBag for some reason.

[dmlloyd]

OK this is interesting; the named provider only exists in Maven 4.x. Otherwise it relies on a secret file called components.xml 😬... I'll see if I can add support for that to BeanBag.

[dmlloyd]

See smallrye/smallrye-beanbag#25

[dmlloyd]

The problem (at least I assume it was the problem) was interesting. There are duplicate artifacts for plexus-sec-dispatcher and plexus-cipher, and we were pulling in both and getting a mishmash of components.

For future reference, the org.sonatype.plexus artifacts are obsolete and the org.codehaus.plexus artifacts are current. Perhaps it's worth an enforcer rule?

[aloubyansky]

Right, I was following the same path earlier today.

[aloubyansky]

Still needed to do more testing.

[aloubyansky]

@dmlloyd any idea how the authenticator below

package org.apache.maven.wagon.providers.http;
...
public class LightweightHttpWagon
    extends StreamWagon
{
...
    private volatile LightweightHttpWagonAuthenticator authenticator;
...
    public void setAuthenticator( LightweightHttpWagonAuthenticator authenticator )
    {
        this.authenticator = authenticator;
    }
...

is supposed to be injected? The authenticator bean is properly discovered and available but not injected. There are no annotations for it, it seems.

[dmlloyd]

This one is declared in a legacy components.xml file, so that's how it's being discovered. I suspect that the problem is related to role-hint - it has a hint of default which should be changed to the empty string but maybe something is going wrong there...?

[aloubyansky]

I don't see how an injection point is configured in this case. It looks like BeanBag's Sisu is looking for annotations but there are none?

[dmlloyd]

This part happens in io.smallrye.beanbag.sisu.Sisu#addBeanFromXml where it iterates over requirements and adds a field injection for each one.

[dmlloyd]

It might be a dependency issue. In the BeanBag tests, I've added this:

        LightweightHttpWagon wagon = mavenFactory.getContainer().requireBean(LightweightHttpWagon.class);
        assertNotNull(wagon);
        assertNotNull(wagon.getAuthenticator());

and it passes. So I wonder if there's another wagon artifact out there or something...?

[aloubyansky]

LightweightHttpWagon is there and is wired in. It's missing the authenticator resulting in NPE.

[aloubyansky]

Hm, but according to your assertions it shouldn't be the case

[aloubyansky]

Ok, it's LightweightHttpsWagon that's missing the authenticator, it extends the http impl.

[dmlloyd]

I've reproduced the problem in a test with the Https one. 👍

[dmlloyd]

Ah, I see: the superclass is not searched for the field.

[aloubyansky]

Thanks @dmlloyd that gets us a bit further. BTW, now I'm seeing these warnings

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by io.smallrye.beanbag.sisu.Sisu (file:/home/aloubyansky/.m2/repository/io/smallrye/beanbag/smallrye-beanbag-sisu/1.2.2/smallrye-beanbag-sisu-1.2.2.jar) to field java.net.Authenticator.requestingHost
WARNING: Please consider reporting this to the maintainers of io.smallrye.beanbag.sisu.Sisu
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

[dmlloyd]

I guess I should exclude all JDK fields then, since even calling trySetAccessible apparently sets it off.

[dmlloyd]

I've added a check like this (n.b. that this is generally useful to avoid these warnings for members of clazz):

Module module = clazz.getModule();
if (! module.isOpen(clazz.getPackageName(), MyClass.class.getModule())) {
    // I cannot access members!
    continue;
}

[aloubyansky]

I'm still seeing it with 1.2.3 though

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by io.smallrye.beanbag.sisu.Sisu (file:/home/aloubyansky/.m2/repository/io/smallrye/beanbag/smallrye-beanbag-sisu/1.2.3/smallrye-beanbag-sisu-1.2.3.jar) to field java.net.Authenticator.requestingHost
WARNING: Please consider reporting this to the maintainers of io.smallrye.beanbag.sisu.Sisu
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

[dmlloyd]

Hmm... what's your JVM version? I wish this included a stack trace...

[aloubyansky]

@dmlloyd this might be it

diff --git a/devtools/maven/src/main/java/io/quarkus/maven/components/QuarkusWorkspaceProvider.java b/devtools/maven/src/main/java/io/quarkus/maven/components/QuarkusWorkspaceProvider.java
index 95994939b6..bf3509dd7c 100644
--- a/devtools/maven/src/main/java/io/quarkus/maven/components/QuarkusWorkspaceProvider.java
+++ b/devtools/maven/src/main/java/io/quarkus/maven/components/QuarkusWorkspaceProvider.java
@@ -7,6 +7,7 @@
 import javax.inject.Singleton;
 
 import org.apache.maven.model.building.ModelBuilder;
+import org.apache.maven.settings.crypto.SettingsDecrypter;
 import org.eclipse.aether.RepositorySystem;
 import org.eclipse.aether.impl.ArtifactResolver;
 import org.eclipse.aether.impl.Deployer;
@@ -41,6 +42,8 @@ public class QuarkusWorkspaceProvider {
 
     private final RemoteRepositoryManager remoteRepoManager;
 
+    private final SettingsDecrypter settingsDecrypter;
+
     private volatile BootstrapMavenContext ctx;
 
     @Inject
@@ -49,13 +52,15 @@ public QuarkusWorkspaceProvider(VersionResolver versionResolver,
             ArtifactResolver artifactResolver,
             MetadataResolver metadataResolver,
             Deployer deployer,
-            RemoteRepositoryManager remoteRepoManager) {
+            RemoteRepositoryManager remoteRepoManager,
+            SettingsDecrypter settingsDecrypter) {
         this.versionResolver = versionResolver;
         this.versionRangeResolver = versionRangeResolver;
         this.artifactResolver = artifactResolver;
         this.metadataResolver = metadataResolver;
         this.deployer = deployer;
         this.remoteRepoManager = remoteRepoManager;
+        this.settingsDecrypter = settingsDecrypter;
     }
 
     public BootstrapMavenContext getMavenContext() {
@@ -89,6 +94,7 @@ protected MavenFactory configureMavenFactory() {
                                     .addBeanInstance(metadataResolver)
                                     .addBeanInstance(deployer)
                                     .addBeanInstance(remoteRepoManager)
+                                    .addBeanInstance(settingsDecrypter)
                                     .addBean(ModelBuilder.class)

Would you mind adding it to your PR? Thanks. I don't think I can push to your branch.

[dmlloyd]

I'm not sure how (or if) this change would cause this dependency error to occur. But, maybe the fix is an exclusion in these TCKs?

[aloubyansky]

Trying to build the tcks module with the previous state of your branch I see

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.2.1:enforce (enforce) on project quarkus-tck-microprofile-opentracing-base: 
[ERROR] Rule 3: org.apache.maven.enforcer.rules.dependency.BannedDependencies failed with message:
[ERROR] io.quarkus:quarkus-tck-microprofile-opentracing-base:jar:999-SNAPSHOT
[ERROR]    org.eclipse.microprofile.opentracing:microprofile-opentracing-tck:jar:3.0
[ERROR]       org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-impl-maven:jar:3.1.4
[ERROR]          org.sonatype.plexus:plexus-sec-dispatcher:jar:1.4 <--- banned via the exclude/include list

which is probably due to this ban <exclude>org.sonatype.plexus:*</exclude> added in this PR.

[aloubyansky]

I'll rebase and look into it.

[dmlloyd]

Ah, I see, that was cut off by the summary making it look like the other dependency was the banned one. I guess the fix is easy enough: add an exclusion plus an explicit dependency on the correct (org.codehaus) artifact instead.

[aloubyansky]

Here is what worked for me

diff --git a/independent-projects/enforcer-rules/src/main/java/io/quarkus/enforcer/DeploymentDependencyRuleSupport.java b/independent-projects/enforcer-rules/src/main/java/io/quarkus/enforcer/DeploymentDependencyRuleSupport.java
index 73a2fa57ae..e0d487c523 100644
--- a/independent-projects/enforcer-rules/src/main/java/io/quarkus/enforcer/DeploymentDependencyRuleSupport.java
+++ b/independent-projects/enforcer-rules/src/main/java/io/quarkus/enforcer/DeploymentDependencyRuleSupport.java
@@ -112,6 +112,9 @@ private Optional<String> parseDeploymentGAV(Artifact artifact) {
         Properties extProperties = new Properties();
         if (artifactFile.isDirectory()) {
             Path extPropertiesPath = artifactFile.toPath().resolve(EXT_PROPERTIES_PATH);
+            if (!Files.exists(extPropertiesPath)) {
+                return Optional.empty();
+            }
             try (InputStreamReader isr = new InputStreamReader(Files.newInputStream(extPropertiesPath),
                     StandardCharsets.UTF_8)) {
                 extProperties.load(isr);
diff --git a/tcks/microprofile-opentelemetry/pom.xml b/tcks/microprofile-opentelemetry/pom.xml
index bbdd787dd0..085f512f14 100644
--- a/tcks/microprofile-opentelemetry/pom.xml
+++ b/tcks/microprofile-opentelemetry/pom.xml
@@ -52,6 +52,12 @@
             <groupId>org.eclipse.microprofile.telemetry.tracing</groupId>
             <artifactId>microprofile-telemetry-tracing-tck</artifactId>
             <version>${microprofile-opentelemetry-tck.version}</version>
+            <exclusions>
+                <exclusion>
+                    <groupId>org.sonatype.plexus</groupId>
+                    <artifactId>*</artifactId>
+                </exclusion>
+            </exclusions>
         </dependency>
 
         <!-- Minimal test dependencies to *-deployment artifacts for consistent build order -->
diff --git a/tcks/microprofile-opentracing/base/pom.xml b/tcks/microprofile-opentracing/base/pom.xml
index d0022bc7fe..5feebe69a0 100644
--- a/tcks/microprofile-opentracing/base/pom.xml
+++ b/tcks/microprofile-opentracing/base/pom.xml
@@ -64,6 +64,12 @@
             <groupId>org.eclipse.microprofile.opentracing</groupId>
             <artifactId>microprofile-opentracing-tck</artifactId>
             <version>${microprofile-opentracing-tck.version}</version>
+            <exclusions>
+                <exclusion>
+                    <groupId>org.sonatype.plexus</groupId>
+                    <artifactId>*</artifactId>
+                </exclusion>
+            </exclusions>
         </dependency>

[aloubyansky]

The following is failing in the main branch as well, so not related to changes in this PR

[INFO] Running io.quarkus.gradle.builder.QuarkusModelBuilderTest
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.602 s <<< FAILURE! - in io.quarkus.gradle.builder.QuarkusModelBuilderTest
[ERROR] io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleDevModel  Time elapsed: 3.48 s  <<< ERROR!
java.lang.NullPointerException: Cannot invoke "io.quarkus.bootstrap.workspace.ArtifactSources.getSourceDirs()" because the return value of "io.quarkus.bootstrap.workspace.WorkspaceModule.getTestSources()" is null

[aloubyansky]

Apparently I was able to push a commit to your branch @dmlloyd. I remember not being able to do it for other branches before. Interesting. I guess we'll want to squash it. Let's hope it'll pass the CI, except for known Amazon native and Gradle model tests.

[aloubyansky]

It passed. I'll try squashing and that should be it.

[quarkus-bot]

Failing Jobs - Building e3ce9e0

Status	Name	Step	Failures	Logs	Raw logs
✖	Native Tests - Amazon	Build	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Amazon #

- Failing: integration-tests/amazon-lambda integration-tests/amazon-lambda-http 

📦 integration-tests/amazon-lambda

✖ io.quarkus.it.amazon.lambda.AmazonLambdaSimpleIT.testSimpleLambdaSuccess - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.amazon.lambda.deployment.DevServicesLambdaProcessor#startEventServer threw an exception: java.lang.RuntimeException: java.util.concurrent.ExecutionException: java.net.BindException: Address already in use

📦 integration-tests/amazon-lambda-http

✖ io.quarkus.it.amazon.lambda.AmazonLambdaSimpleIT.testJaxrsCognitoJWTSecurityContext - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.amazon.lambda.deployment.DevServicesLambdaProcessor#startEventServer threw an exception: java.lang.RuntimeException: java.util.concurrent.ExecutionException: java.net.BindException: Address already in use