Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI uses locally enabled jbang catalogs #33315

Merged
merged 1 commit into from
May 17, 2023

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented May 11, 2023

The pull request allows the CLI to list plugin that are comming from jbang catalogs that have been manually enabled.
Using such plugin was already possible, but the plugins where not listable. This pull request changes that.

@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/platform Issues related to definition and interaction with Quarkus Platform labels May 11, 2023
@iocanel
Copy link
Contributor Author

iocanel commented May 11, 2023

cc @maxandersen: we talked about this earlier today

@iocanel iocanel requested a review from maxandersen May 11, 2023 15:56
@quarkus-bot

This comment has been minimized.

@iocanel iocanel marked this pull request as draft May 12, 2023 05:33
@iocanel iocanel force-pushed the cli-plugin-catalogs branch from acf0def to 9e5e684 Compare May 12, 2023 18:39
@iocanel iocanel marked this pull request as ready for review May 16, 2023 08:19
@quarkus-bot
Copy link

quarkus-bot bot commented May 16, 2023

Failing Jobs - Building 9e5e684

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 19

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/opentelemetry/deployment 
! Skipped: extensions/micrometer-registry-prometheus/deployment extensions/micrometer/deployment extensions/quartz/deployment and 31 more

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.instrumentation.GraphQLOpenTelemetryTest.nestedCdiBeanInsideQueryTraceTest line 133 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: Received: [SpanData{spanContext=ImmutableSpanContext{traceId=d2d3e747aaedefa85296dd5d047e2200, spanId=df38d003f9570064, traceFlags=01, traceState=ArrayBasedTraceState{entries=[]}, remote=false, valid=true}, parentSpanContext=ImmutableSpanContext{traceId=d2d3e747aaedefa85296dd5d047e2200, spanId=ac7daccea0d6f37b, traceFlags=01, traceState=ArrayBasedTraceState{entries=[]}, remote=false, valid=true}, resource=Resource{schemaUrl=https://opentelemetry.io/schemas/1.19.0, attributes={service.name="quarkus-opentelemetry-deployment", service.version="999-SNAPSHOT", telemetry.sdk.language="java", telemetry.sdk.name="opentelemetry", telemetry.sdk.version="1.25.0", webengine.name="Quarkus", webengine.version="999-SNAPSHOT"}}, instrumentationScopeInfo=InstrumentationScopeInfo{name=io.quarkus.opentelemetry, version=null, schemaUrl=null, attributes={}}, name=CustomCDIBean.waitForSomeTime, kind=INTERNAL, startEpochNanos=1684233452266152063, endEpochNanos=16842334...

@iocanel
Copy link
Contributor Author

iocanel commented May 17, 2023

Failures seem irrelevant.

@iocanel iocanel merged commit f6cf227 into quarkusio:main May 17, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants