Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @NotNull annotations #33306

Merged
merged 1 commit into from
May 12, 2023
Merged

Remove @NotNull annotations #33306

merged 1 commit into from
May 12, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented May 11, 2023

This are sometimes added by IntelliJ but they should not be part of the Quarkus codebase

@geoand geoand force-pushed the not-null branch 2 times, most recently from 2aaab40 to 9cb568c Compare May 11, 2023 13:01
@quarkus-bot

This comment has been minimized.

@famod
Copy link
Member

famod commented May 11, 2023

Couldn't we exclude & ban the jar it's coming from?

@gastaldi
Copy link
Contributor

Couldn't we exclude & ban the jar it's coming from?

Not a bad idea, but I think this is not included in the pom.xml, but in the IDEA project directly

@famod
Copy link
Member

famod commented May 11, 2023

It must be in some jar on the classpath, otherwise the compiler plugin would complain, no?

@geoand
Copy link
Contributor Author

geoand commented May 11, 2023

We should definitely ban them, I haven't looked into that

@famod
Copy link
Member

famod commented May 11, 2023

It seems to be coming from org/jetbrains/annotations/24.0.1/annotations-24.0.1.jar.

I think it might be impossible to get rid of it entirely, so that forbidden-apis thingy might be the way to go.

@quarkus-bot
Copy link

quarkus-bot bot commented May 12, 2023

Failing Jobs - Building 5954021

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.KotlinProjectWithCompilerArgsDevModeTest.main line 17 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@geoand geoand merged commit ba59762 into quarkusio:main May 12, 2023
@geoand geoand deleted the not-null branch May 12, 2023 08:44
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants