Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore malformed language ranges when resolving locales for validation #33216

Conversation

marko-bekhta
Copy link
Contributor

Fixes #33150

additionally, I've tried to make both AbstractLocaleResolver and SmallRyeGraphQLLocaleResolver look even more similar.
As for logging a message, I thought since it's not a validation error caused by bad values in the request body, and (hopefully) in most cases, headers aren't typed by users 😃 but generated by an API client, that would indicate a problem in a client, which is more of a dev problem... so they might want to see it 😃
I didn't see any locale-/validation- specific tests in quarkus-integration-test-hibernate-validator-resteasy-reactive or quarkus-integration-test-smallrye-graphql so I haven't introduced any new ones there ...

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented May 9, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit c65e8ba into quarkusio:main May 9, 2023
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone May 9, 2023
@gsmet gsmet modified the milestones: 3.1 - main, 3.0.3.Final May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants