Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose gRPC Reflection service v1 and v1.alpha #33162

Merged
merged 1 commit into from
May 11, 2023

Conversation

cescoffier
Copy link
Member

@cescoffier cescoffier commented May 5, 2023

Fix #33015

@github-actions
Copy link

github-actions bot commented May 5, 2023

🙈 The PR is closed and the preview is expired.

@alesj
Copy link
Contributor

alesj commented May 5, 2023

Looks OK ... but ...
... couldn't we just "redirect" the v1alpha somehow to new v1?
It's doable in new Vert.x gRPC for sure -- as we control the server / handle,
but dunno if it's doable with plain Netty based GRPC ...

@quarkus-bot
Copy link

quarkus-bot bot commented May 5, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@cescoffier
Copy link
Member Author

It's not a redirection... the API is quite different.

@cescoffier cescoffier merged commit 3a10b2e into quarkusio:main May 11, 2023
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone May 11, 2023
@cescoffier cescoffier deleted the grpc-reflection-1.0.alpha branch May 11, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC server reflection is broken in 3.0.1.Final
3 participants