Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing method in native mode when an SSE endpoint returns a Flow.Publisher #33146

Merged
merged 1 commit into from
May 5, 2023
Merged

Fix missing method in native mode when an SSE endpoint returns a Flow.Publisher #33146

merged 1 commit into from
May 5, 2023

Conversation

cescoffier
Copy link
Member

Fix #33106.

@cescoffier cescoffier requested a review from geoand May 5, 2023 09:27
@quarkus-bot quarkus-bot bot added the area/rest label May 5, 2023
@cescoffier cescoffier mentioned this pull request May 5, 2023
Closed
@cescoffier cescoffier changed the title Fix missing method in native mode when an SSE endpoint return a Flow.Publisher Fix missing method in native mode when an SSE endpoint returns a Flow.Publisher May 5, 2023
gsmet
gsmet reviewed May 5, 2023
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for the star import.

.../src/main/java/io/quarkus/resteasy/reactive/server/deployment/ResteasyReactiveProcessor.java Outdated Show resolved Hide resolved
@quarkus-bot

This comment has been minimized.

Sign in to view
@cescoffier
Fix quarkusio#33106.
1f7cfc0 
In addition to Multi, also handle the Flow.Publisher case.
@cescoffier cescoffier force-pushed the fix-flow-issue-native branch from 3cbe472 to 1f7cfc0 Compare May 5, 2023 14:29
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 5, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented May 5, 2023

Failing Jobs - Building 1f7cfc0

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
✖ Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.MultiSourceProjectDevModeTest.main line 22 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes  30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@gsmet gsmet merged commit 8670bba into quarkusio:main May 5, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 5, 2023
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone May 5, 2023
@gsmet gsmet modified the milestones: 3.1 - main, 3.0.3.Final May 9, 2023
@cescoffier cescoffier deleted the fix-flow-issue-native branch May 9, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/rest
Projects
None yet
Milestone
3.0.3.Final
Development

Successfully merging this pull request may close these issues.

Quarkus 3.0.1 behaves different in reactive native mode
4 participants
@cescoffier @gsmet @geoand @gastaldi