Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Kotlin with quarkus update #33108

Merged
merged 1 commit into from
May 4, 2023
Merged

Upgrade Kotlin with quarkus update #33108

merged 1 commit into from
May 4, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented May 3, 2023

Fixes #32768

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven area/platform Issues related to definition and interaction with Quarkus Platform labels May 3, 2023
@gsmet gsmet requested review from ia3andy and aloubyansky May 3, 2023 15:18
ia3andy
ia3andy approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, just a small extra ; or maybe it's GH looking weird

...-common/src/main/java/io/quarkus/devtools/commands/handlers/UpdateProjectCommandHandler.java Outdated Show resolved Hide resolved
@quarkus-bot

This comment has been minimized.

Sign in to view
@gsmet gsmet force-pushed the upgrade-kotlin branch from c15cdbc to 5552e70 Compare May 4, 2023 08:36
@quarkus-bot
Copy link

quarkus-bot bot commented May 4, 2023

Failing Jobs - Building 5552e70

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
⌛ JVM Tests - JDK 17 Windows Build ⚠️ Check → Logs Raw logs
⌛ JVM Tests - JDK 19 Build ⚠️ Check → Logs Raw logs

@gsmet gsmet merged commit 3ae8bff into quarkusio:main May 4, 2023
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone May 4, 2023
@gsmet gsmet modified the milestones: 3.1 - main, 3.0.3.Final May 9, 2023
@gsmet gsmet mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

@aloubyansky aloubyansky Awaiting requested review from aloubyansky

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
3.0.3.Final
Development

Successfully merging this pull request may close these issues.

Update Kotlin version with OpenRewrite
2 participants
@gsmet @ia3andy