Add some hint to inspect the log-level when test-launch failed #33067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doubt it's possible to have a check for this when running a test, because these settings can be "buried" in any config file in any dependency. |
This comment has been minimized.
This comment has been minimized.
snazy
force-pushed
the
launcher-log-level-info
branch
from
58ccd2c to
6fc1f3b
Compare
This comment has been minimized.
This comment has been minimized.
snazy
force-pushed
the
launcher-log-level-info
branch
from
6fc1f3b to
8518576
Compare
This comment has been minimized.
This comment has been minimized.
snazy
force-pushed
the
launcher-log-level-info
branch
from
8518576 to
1f93051
Compare
This comment has been minimized.
This comment has been minimized.
Setting the log-level of a Quarkus app to WARN to even less verbose can break the detection of a successfully started application. This change just adds a note to inspect those settings to the error message(s).
gsmet
force-pushed
the
launcher-log-level-info
branch
from
1f93051 to
80f6ef5
Compare
gsmet
approved these changes
Jun 20, 2023
gsmet
added
the
triage/waiting-for-ci
Failing Jobs - Building 80f6ef5
|
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the log-level of a Quarkus app to WARN to even less verbose can break the detection of a successfully started application. This change just adds a note to inspect those settings to the error message(s).