Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the update guide evergreen #33034

Merged
merged 1 commit into from
May 5, 2023

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented May 1, 2023

I wonder how we can make the update guide evergreen so it doesn't need to be updated.
Here, I've removed almost all references to specific versions, or suggested using the "latest version".
I believe the user can omit --stream=3.0 from the quarkus update --stream=3.0 command. The command seems to default to the latest version, too.

Doc preview link: https://quarkus-pr-main-33034-preview.surge.sh/version/main/guides/update-quarkus
Compare with the current published guide: https://quarkus.io/guides/update-to-quarkus-3

@quarkus-bot
Copy link

quarkus-bot bot commented May 1, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@github-actions
Copy link

github-actions bot commented May 1, 2023

🙈 The PR is closed and the preview is expired.

@rolfedh rolfedh force-pushed the make-update-guide-evergreen branch from cac97de to 96f1d6f Compare May 3, 2023 16:39
@rolfedh
Copy link
Contributor Author

rolfedh commented May 4, 2023

@aloubyansky, would you review/approve this MR?

@rolfedh rolfedh force-pushed the make-update-guide-evergreen branch from 96f1d6f to f4c318c Compare May 4, 2023 11:48
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @gsmet wdyt?

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment about the file name.

The other comment can be addressed now or later.

@rolfedh rolfedh force-pushed the make-update-guide-evergreen branch 3 times, most recently from e8418c9 to 1dad24f Compare May 4, 2023 20:55
@rolfedh rolfedh force-pushed the make-update-guide-evergreen branch from 1dad24f to 8f98a46 Compare May 4, 2023 20:56
@rolfedh rolfedh changed the title [WIP] Make the update guide evergreen Make the update guide evergreen May 4, 2023
@gsmet gsmet merged commit 5bca78d into quarkusio:main May 5, 2023
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone May 5, 2023
@gsmet
Copy link
Member

gsmet commented May 5, 2023

Thanks!

Could you create a PR against the website to install a redirect? I will merge it when I release this change. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants