Dev mode - make it possible to watch files matching a predicate

[mkouba]

• HotDeploymentWatchedFileBuildItem#builder().setPredicate(p).build()

See also https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Allow.20extensions.20to.20watch.20new.20files.20.28with.20restart.29

[mkouba]

And the usage: https://github.com/mkouba/quarkus-qute-server-pages/blob/watch-files/deployment/src/main/java/io/quarkiverse/quteserverpages/deployment/QspProcessor.java#L67-L73

CC @ia3andy @maxandersen

[Sanne]

I haven't checked how this works, but at high level I wonder how this can possibly work. We don't watch every single file on the system, do we? So how can you possibly filter among the whole universe?

I suspect the term "predicate" is used in a different way than I'd expect, it might be worth clarifying at least javadoc, if not finding a better name.

[ia3andy]

I haven't checked how this works, but at high level I wonder how this can possibly work. We don't watch every single file on the system, do we? So how can you possibly filter among the whole universe?

I suspect the term "predicate" is used in a different way than I'd expect, it might be worth clarifying at least javadoc, if not finding a better name.

maybe naming it locationPredicate as the predicate is on the location?

[mkouba]

I haven't checked how this works, but at high level I wonder how this can possibly work. We don't watch every single file on the system, do we? So how can you possibly filter among the whole universe?

@Sanne Of course we don't filter the whole universe. We do filter the set of detected changes. This set is not well documented but from the code it looks like we watch resource dirs of all reloadable modules (as defined in DependenciesFilter.getReloadableModules(ApplicationModel)).

I suspect the term "predicate" is used in a different way than I'd expect, it might be worth clarifying at least javadoc, if not finding a better name.

I will try to add something to the javadoc. Out of curiosity, what's the way you would expect?

[mkouba]

I haven't checked how this works, but at high level I wonder how this can possibly work. We don't watch every single file on the system, do we? So how can you possibly filter among the whole universe?
I suspect the term "predicate" is used in a different way than I'd expect, it might be worth clarifying at least javadoc, if not finding a better name.

maybe naming it locationPredicate as the predicate is on the location?

Makes sense. I will also add some more info to the javadoc.

[mkouba]

We should also document what happens if multiple HotDeploymentWatchedFileBuildItems match the same file. Currently, the final value of isRestartNeeded equals to isRestartNeeded1 || isRestartNeeded2 . I think that we should use the same logic for predicates.

[mkouba]

Those JVM Tests - JDK 19 failures do not seem to be related...

[ia3andy]

I will give it a try today, thanks @mkouba

[mkouba]

I will give it a try today, thanks @mkouba

Hi Andy, did you manage to try this out?

[ia3andy]

It's perfect @mkouba thanks again and sorry for the delay

[mkouba]

@gsmet I cannot make the JVM Tests - JDK 19 pass :-(. But the various failures do not look related...

[quarkus-bot]

Failing Jobs - Building 5c659ef

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✔️	JVM Tests - JDK 17
✖	JVM Tests - JDK 19	Download Maven Repo	⚠️ Check →	Logs	Raw logs

[ia3andy]

Awesome I was waiting for this one :) thanks agian @mkouba