Support Providers in REST Client Reactive from context #32976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
|
@geoand please take a look into this pull request. Thanks! |
|
I'll have a look tomorrow |
|
In the meantime, please rebase onto |
Done |
|
🙏🏼 |
This comment has been minimized.
This comment has been minimized.
geoand
reviewed
May 11, 2023
|
PR updated with adding javadocs to the request and response client filters. |
geoand
approved these changes
May 11, 2023
geoand
approved these changes
May 11, 2023
Sgitario
added
the
triage/waiting-for-ci
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a Providers implementation, so users can look up the Provider instances configured per REST Client Reactive.
In REST Client Classic, we can inject the
Providersinstance via injection (using@Context Providers provider). Initially, I implemented this approach in REST Client Reactive too (including the request context propagation from the server to the client - necessary for the headers), plus using the@RequestScope, and all the tests passed.However, I realized that some tests became flaky because sometimes the application context was null (I didn't find the root cause, but it's likely caused to switching from/to the request context).
Therefore, I took away from the injection approach and implemented this simplistic and straightforward approach: get the Providers instance from the context
context.getProviders()(documentation updated).From my point of view, this approach makes more sense than the one in REST Client Classic and it does not over-complicate the injection mechanism in the REST Client Reactive for a little benefit.
Fix #26003