-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added effective host and mapped port prop to amqp dev services #32731
Added effective host and mapped port prop to amqp dev services #32731
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I've pinged @ozangunalp
We would need to clean up the PR - the update failed. |
rebased which should fix the CI complaint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Thanks! |
The AMQP dev services currently always resolve's the host to be
localhost
. Thats fine when usingquarkus:dev
or in@QuarkusTest
but when running a@QuarkusIntegrationTest
in a container, the app wont be able to connect to the artemis container.This change attempts to follow what other dev service extensions have done (I.e.: postgres/kafka) via the "sharedNetwork" flag. It also adds another prop so the app within the container resolves the correct port, but the test outside of the container can resolve the mapped port via
DevServicesContext
I've tested this via my sample project:
gahealy@rh