Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added effective host and mapped port prop to amqp dev services #32731

Merged
merged 1 commit into from
May 22, 2023
Merged

Added effective host and mapped port prop to amqp dev services #32731

merged 1 commit into from
May 22, 2023

Conversation

garethahealy
Copy link
Contributor

@garethahealy garethahealy commented Apr 18, 2023

The AMQP dev services currently always resolve's the host to be localhost. Thats fine when using quarkus:dev or in @QuarkusTest but when running a @QuarkusIntegrationTest in a container, the app wont be able to connect to the artemis container.

This change attempts to follow what other dev service extensions have done (I.e.: postgres/kafka) via the "sharedNetwork" flag. It also adds another prop so the app within the container resolves the correct port, but the test outside of the container can resolve the mapped port via DevServicesContext

I've tested this via my sample project:

gahealy@rh

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 18, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@garethahealy garethahealy changed the title added effective host and mapped port prop to amqp dev services Added effective host and mapped port prop to amqp dev services Apr 18, 2023
@cescoffier cescoffier requested a review from ozangunalp May 22, 2023 13:36
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I've pinged @ozangunalp

@cescoffier
Copy link
Member

We would need to clean up the PR - the update failed.

@garethahealy
Copy link
Contributor Author

rebased which should fix the CI complaint.

Copy link
Contributor

@ozangunalp ozangunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ozangunalp ozangunalp added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 22, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented May 22, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@cescoffier cescoffier merged commit 0e50d26 into quarkusio:main May 22, 2023
@cescoffier
Copy link
Member

Thanks!

@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 22, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants