-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule to mark Bearer token issues as security issues #32709
Conversation
.github/quarkus-github-bot.yml
Outdated
@@ -226,6 +226,10 @@ triage: | |||
- extensions/security/ | |||
- extensions/elytron | |||
- integration-tests/elytron | |||
- id: bearer-token | |||
labels: [area/security] | |||
title: "Bearer token" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick search and I think we should go with the following. It won't catch too many false positives AFAICS.
title: "Bearer token" | |
title: "bearer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure it's correct, so I'll leave it to @sberyozkin to break the tie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, here's what I did: https://github.com/quarkusio/quarkus/issues?q=is%3Aissue+bearer+in%3Atitle+
But I don't mind either way, feel free to merge if you have a strong opinion about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you are right, it does look good indeed. Let's get @sberyozkin blessing first and then I'll change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this, do you agree @sberyozkin ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, PR should be ready then
Done because quarkusio#32701 was left as `needs-triage`
c30d072
to
869c248
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Georgios
💪🏼 |
Done because #32701 was left as
needs-triage