Update Gradle plugins build #32668
Merged
Update Gradle plugins build #32668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * migration to Gradle Kotlin DSL (much more streamlined IDE support) * use convention plugins in `build-logic/src/main/kotlin` to simplify actual `build.gradle.kts` build scripts * use version catalog for deps (see https://docs.gradle.org/current/userguide/platforms.html#header) * use java toolchain to build plugins (see https://docs.gradle.org/current/userguide/toolchains.html) * use `JavaPluginExtension#withSourcesJar`/`withJavadocJar` instead of older packaging them manually Signed-off-by: Konstantin Gribov <[email protected]>
Updated with `(cd devtools/gradle ; ./gradlew wrapper ; ./gradlew wrapper)` Signed-off-by: Konstantin Gribov <[email protected]>
Only `pom.xml` is published at `io.quarkus:io.quarkus.gradle.plugin` GA coordinates. Same for `io.quarkus.extension`. See https://docs.gradle.org/current/userguide/plugins.html#sec:plugin_markers Signed-off-by: Konstantin Gribov <[email protected]>
Accessing project from task actions is prohibited when configuration cache is used. If Quarkus plugin is to be compatible with CC eventually it should be avoided. Signed-off-by: Konstantin Gribov <[email protected]>
Fixes `integration-tests/gradle` when `.kube/config` has ECDSA keys/certs Signed-off-by: Konstantin Gribov <[email protected]>
quarkus-bot
bot
added
area/devtools
Signed-off-by: Konstantin Gribov <[email protected]>
|
@snazy could you have a look at this one? |
|
At least I should use And since Quarkus 3.x requires java 11+ we could drop |
|
LGTM - especially since I'm a fan of the Kotlin DSL ;) Mind updating the
Yea, that makes sense. |
|
Hm, I guess, the toolchain-change is required (see CI): |
This comment has been minimized.
This comment has been minimized.
|
Yeah, it seems gradle discovered where tooling cache lives on Linux runners but not on Windows ones. |
Signed-off-by: Konstantin Gribov <[email protected]>
…hains Signed-off-by: Konstantin Gribov <[email protected]>
|
PR updated:
|
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
snazy
reviewed
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-logic/src/main/kotlinto simplify actualbuild.gradle.ktsbuild scriptsuse java toolchain to build plugins (see https://docs.gradle.org/current/userguide/toolchains.html)UPD useJavaCompile#options#releaseto set javac--releaseoption to effectively consistently configure source/target compatibility and bootstrap classpathJavaPluginExtension#withSourcesJar/withJavadocJarinstead of older packaging them manuallydevtools/gradleandintegration-tests/gradle)integration-tests/gradle,<type>pom</type>should be used sincecom.gradle.plugin-publishplugin publishes onlypom.xmltoio.quarkus:io.quarkus.gradle.pluginGA coords (see https://docs.gradle.org/current/userguide/plugins.html#sec:plugin_markers)org.bouncycastle:bcpkix-jdk18onto integration test fixtures inintegration-tests/gradleto fix test failure when ECDSA keys/certs present in local.kube/configtask.getLogger()instead oftask.getProject().getLogger()(little bit towards potential configuration cache compatibility)