Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute: Allow to specify default bundle message file without language tag #32667

Conversation

michalvavrik
Copy link
Member

closes: #32354

It is now possible to omit language tag from default message file name.

@michalvavrik michalvavrik requested a review from mkouba April 15, 2023 19:54
@quarkus-bot quarkus-bot bot added area/documentation area/qute The template engine labels Apr 15, 2023
@github-actions
Copy link

github-actions bot commented Apr 15, 2023

🙈 The PR is closed and the preview is expired.

@quarkus-bot

This comment has been minimized.

Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I've just added two minor comments. Thanks.

@michalvavrik michalvavrik force-pushed the feature/qute-default-localized-msg-bundle-file branch from aedd8f3 to 506e3e2 Compare April 17, 2023 09:07
@michalvavrik michalvavrik requested a review from mkouba April 17, 2023 09:27
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 17, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@mkouba mkouba merged commit b687fbb into quarkusio:main Apr 17, 2023
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone Apr 17, 2023
@michalvavrik michalvavrik deleted the feature/qute-default-localized-msg-bundle-file branch April 17, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defining message in msg.properties file doesn't work with default locale
2 participants