-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environmentVariables to gradle task quarkusDev #32662
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
816ffbc
to
0da1e2d
Compare
Thanks @Eng-Fouad, do you think you could add a little test in https://github.com/quarkusio/quarkus/tree/main/integration-tests/gradle for this feature? |
Yes sure, I will do. |
This comment has been minimized.
This comment has been minimized.
ddba37e
to
737fc04
Compare
@aloubyansky I just added a simple test. However, I could not run the Quarkus project on my machine, so I wrote the test without compilation. Could you please verify the test from your side? Thanks. |
Thanks @Eng-Fouad, let's see what the CI says. |
Looks like it's passing @Eng-Fouad, thanks! Would you mind also adding a note about it in https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/gradle-tooling.adoc? It'll end up in https://quarkus.io/guides/gradle-tooling#dev-mode. You could do that in a separate PR, if you like. |
OK, I will add it to docs 👍 |
@aloubyansky using Kotlin DSL, which one is correct?
or
|
737fc04
to
8ffa353
Compare
I chose: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
🙈 The PR is closed and the preview is expired. |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
does this not overwrite users actual environment meaning users with FOO explicitly set in build.gradle can no longer do:
as gradle build will override the environment? That is not good IMO as it changes the order of priority/locality. |
Closes #32661