Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.13] Sanitize the behavior of provided ExceptionMapper classes in dev-mode #32619

Merged
merged 2 commits into from
Apr 17, 2023
Merged

[2.13] Sanitize the behavior of provided ExceptionMapper classes in dev-mode #32619

merged 2 commits into from
Apr 17, 2023

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Apr 13, 2023 •
edited
Loading

geoand added 2 commits April 13, 2023 09:34
@geoand @gastaldi
Sanitize the behavior of provided ExceptionMapper classes in dev-mode
d96f118 
User provided ExceptionMapper classes now takes precedence
over the Quarkus provided NotFoundExceptionMapper.

This is done in a way that does not change anything but this
specific behavior, everything else concerning exception handling
continues to work as before.
Note also that this does not change the spec compliance in
any way

Fixes: quarkusio#7883
@geoand @gastaldi
Fix javadoc of ServerExceptionMapper
9682199
@gastaldi gastaldi requested review from gsmet and geoand April 13, 2023 12:44
geoand
geoand approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand
Copy link
Contributor

geoand commented Apr 13, 2023

cc @aldettinger @tqvarnst

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 13, 2023
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 17, 2023

Failing Jobs - Building 9682199

Status Name Step Failures Logs Raw logs
✖ Gradle Tests - JDK 11 Build Failures Logs Raw logs
✔️ Gradle Tests - JDK 11 Windows
✖ JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18
✔️ Maven Tests - JDK 11
⌛ Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.KotlinProjectWithCompilerArgsDevModeTest.main line 17 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/logging-gelf

📦 integration-tests/logging-gelf

✖ io.quarkus.logging.gelf.it.GelfLogHandlerTest.test line 32 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.logging.gelf.it.GelfLogHandlerTest expected: not <null> within 20 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

@gastaldi gastaldi merged commit ae4f567 into quarkusio:2.13 Apr 17, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 17, 2023
@gsmet gsmet changed the title Sanitize the behavior of provided ExceptionMapper classes in dev-mode [2.13] Sanitize the behavior of provided ExceptionMapper classes in dev-mode Apr 18, 2023
@gastaldi gastaldi deleted the exception_mapper_213 branch April 20, 2023 00:34
@rsvoboda
Copy link
Member

@gsmet / @gastaldi is this gonna be in 2.13.8? If so, please set the milestone.

@gsmet gsmet added this to the 2.13.8.Final milestone May 22, 2023
@gsmet
Copy link
Member

gsmet commented May 22, 2023

Right, done.

@rsvoboda
Copy link
Member

Thanks @gsmet

@AnetaCadova AnetaCadova mentioned this pull request Aug 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldettinger aldettinger aldettinger approved these changes

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/rest
Projects
None yet
Milestone
2.13.8.Final
Development

Successfully merging this pull request may close these issues.
5 participants
@gastaldi @geoand @rsvoboda @gsmet @aldettinger