Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port NativeConfig to @ConfigMapping #32294

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Port NativeConfig to @ConfigMapping #32294

merged 1 commit into from
Apr 13, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 31, 2023 •
edited
Loading

Opening as a draft for now as this is based on #32276

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 31, 2023

/cc @yrodiere (hibernate-search)

@geoand
Copy link
Contributor Author

geoand commented Mar 31, 2023

cc @gsmet @radcortez

@yrodiere
Copy link
Member

@geoand this will very likely conflict with #32236

@geoand
Copy link
Contributor Author

geoand commented Mar 31, 2023

This can wait, no rush

@geoand geoand force-pushed the config-mapping-native branch from 4914d08 to a038a4e Compare April 11, 2023 09:00
@geoand geoand marked this pull request as ready for review April 11, 2023 09:01
@quarkus-bot quarkus-bot bot added the area/persistence OBSOLETE, DO NOT USE label Apr 11, 2023
@geoand
Copy link
Contributor Author

geoand commented Apr 11, 2023

PR rebased onto main

@geoand geoand force-pushed the config-mapping-native branch from a038a4e to 7c58b58 Compare April 11, 2023 09:02
@yrodiere yrodiere removed area/persistence OBSOLETE, DO NOT USE area/hibernate-search Hibernate Search labels Apr 11, 2023
@quarkus-bot

This comment has been minimized.

Sign in to view
@geoand
Copy link
Contributor Author

geoand commented Apr 11, 2023

The maven failures maybe related, I'll have a look tomorrow

@geoand geoand force-pushed the config-mapping-native branch from 7c58b58 to ee68888 Compare April 12, 2023 05:34
@quarkus-bot quarkus-bot bot added area/maven area/persistence OBSOLETE, DO NOT USE labels Apr 12, 2023
@geoand geoand force-pushed the config-mapping-native branch from ee68888 to 0f588c8 Compare April 12, 2023 05:46
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 12, 2023

Failing Jobs - Building 0f588c8

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 19

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/scheduler/deployment 
! Skipped: extensions/quartz/deployment extensions/spring-scheduled/deployment integration-tests/devmode and 4 more

📦 extensions/scheduler/deployment

✖ io.quarkus.scheduler.test.programmatic.ProgrammaticJobTimeZoneTest.testJobs line 66 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

@geoand geoand requested a review from radcortez April 12, 2023 11:16
@geoand geoand merged commit f9d0518 into quarkusio:main Apr 13, 2023
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone Apr 13, 2023
@geoand geoand deleted the config-mapping-native branch May 11, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radcortez radcortez radcortez approved these changes

Assignees
No one assigned
Labels
area/core area/maven area/persistence OBSOLETE, DO NOT USE triage/flaky-test
Projects
None yet
Milestone
3.1.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@geoand @yrodiere @radcortez