-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.16.6 backports 1 #32132
Merged
Merged
2.16.6 backports 1 #32132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/core
area/devtools
Issues/PR related to maven, gradle, platform and cli tooling/plugins
area/graphics
area/oidc
area/reactive-messaging
area/rest
area/smallrye
area/testing
labels
Mar 25, 2023
This comment has been minimized.
This comment has been minimized.
gsmet
force-pushed
the
2.16.6-backports-1
branch
from
March 25, 2023 14:51
9d75f3c
to
abdbc29
Compare
This comment has been minimized.
This comment has been minimized.
Enables enforcing podman on systems where both podman and docker are available
e.g. Before: ``` WARN [io.qua.run.uti.ContainerRuntimeUtil] (main) Command "docker" exited with error code 1. Rootless container runtime detection might not be reliable. ``` after: ``` WARN [io.qua.run.uti.ContainerRuntimeUtil] (main) Command "docker info" exited with error code 1. Rootless container runtime detection might not be reliable or the container service is not running at all. ``` plus with `-Dquarkus.log.level=DEBUG` it logs: ``` DEBUG [io.qua.run.uti.ContainerRuntimeUtil] (main) Command "docker info" output: Client: Context: default Debug Mode: false Plugins: buildx: Docker Buildx (Docker Inc.) Version: v0.10.2 Path: /usr/libexec/docker/cli-plugins/docker-buildx compose: Docker Compose (Docker Inc.) Version: v2.16.0 Path: /usr/libexec/docker/cli-plugins/docker-compose scan: Docker Scan (Docker Inc.) Version: v0.23.0 Path: /usr/libexec/docker/cli-plugins/docker-scan Server: ERROR: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running? ```
With this change, the detected container runtime is cached per JVM run so as it is not checked again regardless of the classloader loading the ContainerRuntimeUtil class. The rootless attribute of such runtime is lazily fetched once as needed. (cherry picked from commit 5c58a03)
(cherry picked from commit 6678ea5)
(cherry picked from commit 4c449e0)
(cherry picked from commit f8c61cf)
…uation\nwhere there is no container runtime working and none is needed. (cherry picked from commit 781eb53)
(cherry picked from commit ea1728b)
(cherry picked from commit 38d3c0d)
Under certain configurations (e.g. in quarkusio#31930) the substitution fails with: ``` Error: Substitution target for io.quarkus.smallrye.jwt.build.runtime.graalvm.Target_org_jose4j_jwk_OctetKeyPairJsonWebKey is not loaded. Use field `onlyWith` in the `TargetClass` annotation to make substitution only active when needed. com.oracle.svm.core.util.UserError$UserException: Substitution target for io.quarkus.smallrye.jwt.build.runtime.graalvm.Target_org_jose4j_jwk_OctetKeyPairJsonWebKey is not loaded. Use field `onlyWith` in the `TargetClass` annotation to make substitution only active when needed. ``` which indicates that the class being substituted cannot be located on the classpath. (cherry picked from commit 1b143e9)
… Hibernate ORM codestart 1. It's not necessary: if you're using dev services, this will be set implicitly in dev mode and test mode. 2. It's incorrect and dangerous: this setting should be applied to the dev and test profile explicitly, otherwise it will lead to dropping the whole database content in production... (cherry picked from commit 94029e3)
- Assign the bean as unremovable - Kafka serde discovery Fixes quarkusio#32002 (cherry picked from commit ab62972)
(cherry picked from commit 402a9ba)
(cherry picked from commit 6737655)
(cherry picked from commit 298b008)
(cherry picked from commit 6d46c2e)
old registry k8s.grc.io will be phased out use registry.k8s.io instead fixes quarkusio#32041 (cherry picked from commit 07d2639)
…e projects (cherry picked from commit be495a1)
Fixes quarkusio#32106 (cherry picked from commit 82e62c7)
(cherry picked from commit 736ba35)
…ndencies when bootstrapping for CT (cherry picked from commit 18e4136)
(cherry picked from commit 551fd86)
(cherry picked from commit a2914f7)
(cherry picked from commit f964a49)
- if a bean that has iterable in its set of bean types is used as an iterable in a loop section then the hints are not processed correctly (cherry picked from commit ed7e3c5)
gsmet
force-pushed
the
2.16.6-backports-1
branch
from
April 2, 2023 16:33
abdbc29
to
9dbfe9c
Compare
quarkus-bot
bot
added
area/amazon-lambda
area/dependencies
Pull requests that update a dependency file
area/documentation
area/keycloak
area/kubernetes
area/qute
The template engine
labels
Apr 2, 2023
🎊 PR Preview 95e97b0 has been successfully built and deployed to https://quarkus-pr-main-32132-preview.surge.sh/version/main/guides/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/amazon-lambda
area/core
area/dependencies
Pull requests that update a dependency file
area/devtools
Issues/PR related to maven, gradle, platform and cli tooling/plugins
area/documentation
area/graphics
area/infra
internal and infrastructure related issues
area/keycloak
area/kubernetes
area/oidc
area/qute
The template engine
area/reactive-messaging
area/rest
area/smallrye
area/testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't merge, I will merge it myself.