Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now unnecessary logging configuration for k8s config #32007

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Remove now unnecessary logging configuration for k8s config #32007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions ...ment/src/main/java/io/quarkus/kubernetes/config/deployment/KubernetesConfigProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,10 @@

import java.util.List;

import org.jboss.logmanager.Level;

import io.quarkus.deployment.annotations.BuildProducer;
import io.quarkus.deployment.annotations.BuildStep;
import io.quarkus.deployment.annotations.ExecutionTime;
import io.quarkus.deployment.annotations.Record;
import io.quarkus.deployment.builditem.LogCategoryBuildItem;
import io.quarkus.deployment.builditem.RunTimeConfigurationSourceValueBuildItem;
import io.quarkus.kubernetes.client.runtime.KubernetesClientBuildConfig;
import io.quarkus.kubernetes.config.runtime.KubernetesConfigBuildTimeConfig;
Expand Down Expand Up @@ -71,12 +68,4 @@ public void handleAccessToSecrets(KubernetesConfigSourceConfig config,

recorder.warnAboutSecrets(config, buildTimeConfig);
}

// done in order to ensure that http logs aren't shown by default which happens because of the interplay between
// not yet setup logging (as the bootstrap config runs before logging is set up) and the configuration
// of the okhttp3.logging.HttpLoggingInterceptor by io.fabric8.kubernetes.client.utils.HttpClientUtils
@BuildStep
public void produceLoggingCategories(BuildProducer<LogCategoryBuildItem> categories) {
categories.produce(new LogCategoryBuildItem("okhttp3.OkHttpClient", Level.WARN));
}
}