Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hibernate ORM and Search DEV bean should be available in DEV launch mode #32005

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Hibernate ORM and Search DEV bean should be available in DEV launch mode #32005

merged 1 commit into from
Mar 21, 2023

Conversation

michalvavrik
Copy link
Member

fixes: #32004

@michalvavrik michalvavrik requested a review from yrodiere March 21, 2023 13:26
@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/persistence OBSOLETE, DO NOT USE labels Mar 21, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 21, 2023

/cc @Sanne (hibernate-orm), @gsmet (hibernate-orm,hibernate-search), @yrodiere (hibernate-orm,hibernate-search)

yrodiere
yrodiere approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

I really thought the dev profile was always active in dev mode, and that you could only add more profiles... I guess I was wrong 🤷

@gsmet gsmet changed the title Hiberante ORM and Search DEV bean should be available in DEV launch mode Hibernate ORM and Search DEV bean should be available in DEV launch mode Mar 21, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 21, 2023

Failing Jobs - Building d9a8dde

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
⌛ Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.MultiSourceProjectDevModeTest.main line 22 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@michalvavrik
Copy link
Member Author

Checked MultiSourceProjectDevModeTest, it seems unrelated.

@yrodiere yrodiere merged commit 9e7ac75 into quarkusio:main Mar 21, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 21, 2023
@michalvavrik michalvavrik deleted the feature/hibernate-dev-mode-dont-depend-on-profile branch March 21, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere approved these changes

Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/persistence OBSOLETE, DO NOT USE kind/bugfix triage/flaky-test
Projects
None yet
Milestone
3.0.0.Beta1
Development

Successfully merging this pull request may close these issues.

Hibernate ORM and Search extensions now requires dev build profile
2 participants
@michalvavrik @yrodiere