Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump OTel to 1.24+1.25 #32001

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Bump OTel to 1.24+1.25 #32001

merged 1 commit into from
Apr 21, 2023

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Mar 21, 2023 •
edited
Loading

aws.contrib dependencies are no longer needed.
Includes upgrade to 1.24 + 1.25.
Requires SR Reactive Messaging.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/tracing labels Mar 21, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 21, 2023

/cc @radcortez (opentelemetry)

@brunobat brunobat requested review from radcortez and alesj March 21, 2023 16:16
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@brunobat
Copy link
Contributor Author

brunobat commented Mar 22, 2023 •
edited
Loading

@ozangunalp have you seen these reactive messaging errors happening elsewhere as well?
(edit)
We need to release SM reactive messaging to be able to upgrade Quarkus.

@ozangunalp
Copy link
Contributor

If I understand correctly there is yet another breaking change in Otel 1.24 in an API we use in reactive messaging.

There is a failed dependabot PR in smallrye reactive messaging but I didn't have time to look into it.

@brunobat
Copy link
Contributor Author

Waiting for the next release of SR Reactive Messaging

@brunobat brunobat mentioned this pull request Mar 31, 2023
Merged
@quarkus-bot

This comment has been minimized.

Sign in to view
@brunobat
Copy link
Contributor Author

Due to the wait for the SM Reactive Messaging release, OTel version got bumped again and we agree to skip 1.24.
Updated this PR.

@brunobat brunobat requested a review from radcortez April 20, 2023 09:42
@brunobat brunobat changed the title Bump OTel to 1.24 Bump OTel to 1.24+1.25 Apr 20, 2023
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 21, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@brunobat
Copy link
Contributor Author

@geoand do you mind if I merge this?

@geoand
Copy link
Contributor

geoand commented Apr 21, 2023

Fine with me!

@brunobat brunobat merged commit 9333964 into quarkusio:main Apr 21, 2023
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone Apr 21, 2023
@brunobat brunobat deleted the bump-otel-1-24 branch August 21, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radcortez radcortez radcortez approved these changes

@ozangunalp ozangunalp ozangunalp approved these changes

@alesj alesj Awaiting requested review from alesj

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/tracing
Projects
None yet
Milestone
3.1.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@brunobat @ozangunalp @geoand @radcortez