Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New home for Narayana LRA coordinator Docker images #31959

Merged
merged 1 commit into from
Mar 18, 2023
Merged

New home for Narayana LRA coordinator Docker images #31959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/main/asciidoc/lra.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ quarkus.lra.coordinator-url=http://localhost:8080/lra-coordinator
----

For a Narayana coordinator the path component of the url is normally `lra-coordinator`.
Coordinators can be obtained from `https://hub.docker.com/r/jbosstm/lra-coordinator`
Coordinators can be obtained from https://quay.io/repository/jbosstm/lra-coordinator
or you can build your own coordinator using a maven pom that includes the appropriate
dependencies. A Quarkus quickstart will be provided to show how to do this, or you can
take a look at one of the https://github.com/jbosstm/quickstart/tree/master/rts/lra-examples/lra-coordinator[Narayana quickstarts].
Expand Down
2 changes: 1 addition & 1 deletion ...rayana-lra/src/test/java/org/acme/quickstart/lra/LRAParticipantTestResourceLifecycle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public static String getCoordinatorEndpoint() {

@Override
public Map<String, String> start() {
registry = new GenericContainer<>("jbosstm/lra-coordinator:5.12.0.Final")
registry = new GenericContainer<>("quay.io/jbosstm/lra-coordinator:latest")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I like latest, but let's go with it for now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I decided to make things consistent between this and the MP tests. If it becomes a problem, we can drop it easily.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

.withExposedPorts(8080)
.withEnv("QUARKUS_PROFILE", "prod");
registry.start();
Expand Down
2 changes: 1 addition & 1 deletion tcks/microprofile-lra/src/main/java/io/quarkus/tck/lra/LRACoordinatorManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class LRACoordinatorManager {
public void beforeClass(
@Observes(precedence = DEFAULT_PRECEDENCE) org.jboss.arquillian.test.spi.event.suite.BeforeSuite event) {
LOGGER.debug("Starting LRA coordinator on port " + coordinatorPort);
coordinatorContainer = new GenericContainer<>(DockerImageName.parse("jbosstm/lra-coordinator:latest"))
coordinatorContainer = new GenericContainer<>(DockerImageName.parse("quay.io/jbosstm/lra-coordinator:latest"))
// lra-coordinator is a Quarkus service
.withEnv("QUARKUS_HTTP_PORT", String.valueOf(coordinatorPort))
// need to run with host network because coordinator calls the TCK services from the container
Expand Down