Added dev cli help for test command #31956
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
sdaschner
force-pushed
the
command-line-help
branch
from
1c96751 to
949df75
Compare
|
@gsmet Maybe you or someone else could have a look? :) |
|
i think #31956 might fix it too? |
|
sorry meant #33516 |
Only had a glance at the code, but this might fix the help, yes. I remember also refactoring the command hierarchy, but it has been a while, so not sure if that's still needed or up-to-date. It probably makes sense to focus on the other PR first, and after merging I can update here and see if there's still something open. |
|
Sorry for the late reply, this has fallen through the cracks. I think #33516 should have fixed the issue. Do you think your PR still has value and is worthy of a rebase? If so I let you do that and I will have a look afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that in the dev cli (
quarkus:dev, pressing:), thetestcommand had no-hoption associated. Added this and refactored the code a bit by adding aQuarkusGroupCommandbase class.Connected to #22345