New dev UI for Hibernate extensions #31946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/flyway
area/hibernate-orm
yrodiere
force-pushed
the
hibernate-dev-ui
branch
from
3a8533c to
b738990
Compare
yrodiere
commented
Mar 17, 2023
.../hibernate-search-+-elasticsearch/hibernate-search-orm-elasticsearch-indexed-entity-types.js
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
yrodiere
force-pushed
the
hibernate-dev-ui
branch
from
b738990 to
fc7219a
Compare
This comment has been minimized.
This comment has been minimized.
phillip-kruger
requested changes
Mar 18, 2023
...te-orm/deployment/src/main/resources/dev-ui/hibernate-orm/hibernate-orm-persistence-units.js
Outdated
Show resolved
Hide resolved
...ernate-orm/deployment/src/main/resources/dev-ui/hibernate-orm/hibernate-orm-named-queries.js
Outdated
Show resolved
Hide resolved
...bernate-orm/deployment/src/main/resources/dev-ui/hibernate-orm/hibernate-orm-entity-types.js
Outdated
Show resolved
Hide resolved
...bernate-orm/deployment/src/main/resources/dev-ui/hibernate-orm/hibernate-orm-entity-types.js
Outdated
Show resolved
Hide resolved
...ernate-orm/deployment/src/main/resources/dev-ui/hibernate-orm/hibernate-orm-named-queries.js
Outdated
Show resolved
Hide resolved
...-tests/devmode/src/test/java/io/quarkus/test/devconsole/DevConsoleHibernateOrmSmokeTest.java
Outdated
Show resolved
Hide resolved
.../hibernate-search-+-elasticsearch/hibernate-search-orm-elasticsearch-indexed-entity-types.js
Outdated
Show resolved
Hide resolved
.../hibernate-search-+-elasticsearch/hibernate-search-orm-elasticsearch-indexed-entity-types.js
Outdated
Show resolved
Hide resolved
.../hibernate-search-+-elasticsearch/hibernate-search-orm-elasticsearch-indexed-entity-types.js
Outdated
Show resolved
Hide resolved
...te-orm/deployment/src/main/resources/dev-ui/hibernate-orm/hibernate-orm-persistence-units.js
Show resolved
Hide resolved
|
@yrodiere on a separate note, I got an error when using dev services for elastic search. I think it might be because I am using podman, but I'll create an issue and the fix I had to do in a PR if you can please have a look at that |
…rch-orm-elasticsearch Just so I can run quarkus:dev.
We don't want to re-interpret the config, in particular.
yrodiere
commented
Mar 20, 2023
...ernate-orm/deployment/src/main/resources/dev-ui/hibernate-orm/hibernate-orm-named-queries.js
Outdated
Show resolved
Hide resolved
...-tests/devmode/src/test/java/io/quarkus/test/devconsole/DevConsoleHibernateOrmSmokeTest.java
Outdated
Show resolved
Hide resolved
yrodiere
force-pushed
the
hibernate-dev-ui
branch
from
fc7219a to
50a0589
Compare
This comment has been minimized.
This comment has been minimized.
yrodiere
added
the
triage/waiting-for-ci
quarkus-bot
bot
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31366
Fixes #31367
As far as I can tell, only ORM and Search had custom Dev UI cards, so this should be about it.
Note I didn't try to improve on the old Dev UI; I just ported it to the new one. And given how long that's taken me (I'm not a frontend person), improvements will have to wait :)
To test the new Dev UI, I recommend starting the Hibernate Search quickstart from this branch of my fork: https://github.com/yrodiere/quarkus-quickstarts/tree/hibernate-new-devui-testing
The
otherPU on that branch has no Elasticsearch behind it, so that's useful to test mass indexing failures.